From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA6BAC48BDF for ; Tue, 15 Jun 2021 06:26:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C9E09613CC for ; Tue, 15 Jun 2021 06:26:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230106AbhFOG2j convert rfc822-to-8bit (ORCPT ); Tue, 15 Jun 2021 02:28:39 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:10069 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230012AbhFOG2g (ORCPT ); Tue, 15 Jun 2021 02:28:36 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4G3ytx0cSszZf5H; Tue, 15 Jun 2021 14:23:37 +0800 (CST) Received: from dggpeml500018.china.huawei.com (7.185.36.186) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 15 Jun 2021 14:26:31 +0800 Received: from dggema753-chm.china.huawei.com (10.1.198.195) by dggpeml500018.china.huawei.com (7.185.36.186) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Tue, 15 Jun 2021 14:26:31 +0800 Received: from dggema753-chm.china.huawei.com ([10.9.48.84]) by dggema753-chm.china.huawei.com ([10.9.48.84]) with mapi id 15.01.2176.012; Tue, 15 Jun 2021 14:26:31 +0800 From: liweihang To: Andrew Lunn CC: "davem@davemloft.net" , "kuba@kernel.org" , "hkallweit1@gmail.com" , "netdev@vger.kernel.org" , Linuxarm , liangwenpeng Subject: Re: [PATCH net-next 7/8] net: phy: remove unnecessary line continuation Thread-Topic: [PATCH net-next 7/8] net: phy: remove unnecessary line continuation Thread-Index: AQHXXoyjdl2f1xhmskyc5eJ5hMvy+A== Date: Tue, 15 Jun 2021 06:26:31 +0000 Message-ID: <3315ce40e68e4d55ab56e365d2d724a9@huawei.com> References: <1623393419-2521-1-git-send-email-liweihang@huawei.com> <1623393419-2521-8-git-send-email-liweihang@huawei.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.67.100.165] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2021/6/12 0:07, Andrew Lunn wrote: >> - phy_write(phydev, ET1011C_CONFIG_REG, val\ >> - | ET1011C_GMII_INTERFACE\ >> - | ET1011C_SYS_CLK_EN\ >> + phy_write(phydev, ET1011C_CONFIG_REG, val >> + | ET1011C_GMII_INTERFACE >> + | ET1011C_SYS_CLK_EN >> | ET1011C_TX_FIFO_DEPTH_16); > > Please put the | at the end of the line, not the beginning of the next > line. > > Thanks > Andrew > Sure, thank you. Weihang