From: David Ahern <dsahern@gmail.com>
To: Ido Schimmel <idosch@idosch.org>, netdev@vger.kernel.org
Cc: roopa@nvidia.com, mlxsw@nvidia.com, Ido Schimmel <idosch@nvidia.com>
Subject: Re: [PATCH iproute2-next 0/2] ip: Nexthop flags extensions
Date: Sun, 22 Nov 2020 12:47:23 -0700 [thread overview]
Message-ID: <335227b5-56e6-3312-d090-84d2fabff32b@gmail.com> (raw)
In-Reply-To: <20201119135731.410986-1-idosch@idosch.org>
On 11/19/20 6:57 AM, Ido Schimmel wrote:
> From: Ido Schimmel <idosch@nvidia.com>
>
> Patch #1 prints the recently added 'RTNH_F_TRAP' flag.
>
> Patch #2 makes sure that nexthop flags are always printed for nexthop
> objects. Even when the nexthop does not have a device, such as a
> blackhole nexthop or a group.
>
> Example output with netdevsim:
>
> # ip nexthop
> id 1 via 192.0.2.2 dev eth0 scope link trap
> id 2 blackhole trap
> id 3 group 2 trap
>
> Example output with mlxsw:
>
> # ip nexthop
> id 1 via 192.0.2.2 dev swp3 scope link offload
> id 2 blackhole offload
> id 3 group 2 offload
>
> Tested with fib_nexthops.sh that uses "ip nexthop" output:
>
> Tests passed: 164
> Tests failed: 0
>
> Ido Schimmel (2):
> ip route: Print "trap" nexthop indication
> nexthop: Always print nexthop flags
>
> ip/ipnexthop.c | 3 +--
> ip/iproute.c | 2 ++
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
applied to iproute2-next, without preferential treatment.
prev parent reply other threads:[~2020-11-22 19:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 13:57 [PATCH iproute2-next 0/2] ip: Nexthop flags extensions Ido Schimmel
2020-11-19 13:57 ` [PATCH iproute2-next 1/2] ip route: Print "trap" nexthop indication Ido Schimmel
2020-11-19 13:57 ` [PATCH iproute2-next 2/2] nexthop: Always print nexthop flags Ido Schimmel
2020-11-22 19:47 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=335227b5-56e6-3312-d090-84d2fabff32b@gmail.com \
--to=dsahern@gmail.com \
--cc=idosch@idosch.org \
--cc=idosch@nvidia.com \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).