From: "Björn Töpel" <bjorn.topel@intel.com>
To: "Maciej Fijalkowski" <maciej.fijalkowski@intel.com>,
"Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: daniel@iogearbox.net, ast@kernel.org, bpf@vger.kernel.org,
netdev@vger.kernel.org, andrii@kernel.org,
magnus.karlsson@intel.com, ciara.loftus@intel.com
Subject: Re: [PATCH bpf-next 1/3] libbpf: xsk: use bpf_link
Date: Tue, 16 Feb 2021 10:15:53 +0100 [thread overview]
Message-ID: <33b54a25-a35a-6991-6831-f551670f5556@intel.com> (raw)
In-Reply-To: <20210216020128.GA9572@ranger.igk.intel.com>
On 2021-02-16 03:01, Maciej Fijalkowski wrote:
> On Mon, Feb 15, 2021 at 08:35:29PM +0100, Toke Høiland-Jørgensen wrote:
>> Björn Töpel <bjorn.topel@intel.com> writes:
[...]
>>>
>>> I'd say it's depending on the libbpf 1.0/libxdp merge timeframe. If
>>> we're months ahead, then I'd really like to see this in libbpf until the
>>> merge. However, I'll leave that for Magnus/you to decide!
>
> WDYM by libbpf 1.0/libxdp merge? I glanced through thread and I saw that
> John was also not aware of that. Not sure where it was discussed?
>
Oh, right. Yeah, we've had some offlist discussions about moving the
AF_XDP functionality from libbpf to libxdp in the libbpf 1.0 timeframe.
> If you're saying 'merge', then is libxdp going to be a part of kernel or
> as an AF-XDP related guy I would be forced to include yet another
> repository in the BPF developer toolchain? :<
>
The AF_XDP functionality of libbpf will be part of libxdp, which is not
in the kernel tree. libxdp depend on libbpf, which includes the core BPF
functionality. For AF_XDP this is a good thing IMO. libxdp includes more
higher lever abstractions than libbpf, which is more aligned to AF_XDP.
Yes, that would mean that you would get another dependency for AF_XDP,
and one that is not in the kernel tree. For most *users* this is not a
problem, in fact it might be easier to consume and to contribute for
most users. We can't optimize just for the kernel hackers. ;-)
Björn
[...]
next prev parent reply other threads:[~2021-02-16 9:17 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 15:46 [PATCH bpf-next 0/3] Introduce bpf_link in libbpf's xsk Maciej Fijalkowski
2021-02-15 15:46 ` [PATCH bpf-next 1/3] libbpf: xsk: use bpf_link Maciej Fijalkowski
2021-02-15 17:07 ` Toke Høiland-Jørgensen
2021-02-15 17:38 ` Björn Töpel
2021-02-15 19:35 ` Toke Høiland-Jørgensen
2021-02-16 2:01 ` Maciej Fijalkowski
2021-02-16 9:15 ` Björn Töpel [this message]
2021-02-16 10:27 ` Toke Høiland-Jørgensen
2021-02-16 20:15 ` Maciej Fijalkowski
2021-02-15 20:22 ` John Fastabend
2021-02-15 21:38 ` Toke Høiland-Jørgensen
2021-02-16 0:18 ` John Fastabend
2021-02-16 2:23 ` Maciej Fijalkowski
2021-02-16 9:23 ` Björn Töpel
2021-02-16 10:36 ` Toke Høiland-Jørgensen
2021-02-23 1:15 ` Andrii Nakryiko
2021-02-17 2:23 ` Dan Siemon
2021-02-17 7:16 ` Magnus Karlsson
2021-02-17 7:36 ` Magnus Karlsson
2021-02-16 2:10 ` Maciej Fijalkowski
2021-02-15 20:49 ` John Fastabend
2021-02-16 2:38 ` Maciej Fijalkowski
2021-02-16 18:19 ` John Fastabend
2021-02-16 20:10 ` Maciej Fijalkowski
2021-02-16 9:20 ` Björn Töpel
2021-02-16 10:39 ` Toke Høiland-Jørgensen
2021-02-16 19:15 ` John Fastabend
2021-02-16 20:50 ` Maciej Fijalkowski
2021-02-16 21:17 ` John Fastabend
2021-02-15 15:46 ` [PATCH bpf-next 2/3] libbpf: clear map_info before each bpf_obj_get_info_by_fd Maciej Fijalkowski
2021-02-15 20:33 ` John Fastabend
2021-02-16 2:42 ` Maciej Fijalkowski
2021-02-15 15:46 ` [PATCH bpf-next 3/3] samples: bpf: do not unload prog within xdpsock Maciej Fijalkowski
2021-02-15 20:24 ` John Fastabend
2021-02-16 9:22 ` Björn Töpel
2021-02-16 14:15 ` Maciej Fijalkowski
2021-02-15 16:07 ` [PATCH bpf-next 0/3] Introduce bpf_link in libbpf's xsk Björn Töpel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33b54a25-a35a-6991-6831-f551670f5556@intel.com \
--to=bjorn.topel@intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=ciara.loftus@intel.com \
--cc=daniel@iogearbox.net \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).