From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73020ECAAD3 for ; Wed, 14 Sep 2022 17:31:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229810AbiINRbB (ORCPT ); Wed, 14 Sep 2022 13:31:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229797AbiINRbA (ORCPT ); Wed, 14 Sep 2022 13:31:00 -0400 Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2EB786047; Wed, 14 Sep 2022 10:30:57 -0700 (PDT) Received: from [192.168.1.103] (31.173.80.79) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.986.14; Wed, 14 Sep 2022 20:30:49 +0300 Subject: Re: [PATCH net-next v3] ravb: Add RZ/G2L MII interface support To: Biju Das , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni CC: Prabhakar Mahadev Lad , "netdev@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , Geert Uytterhoeven , Chris Paterson , Biju Das References: <20220914064730.1878211-1-biju.das.jz@bp.renesas.com> <631f13b7-9cab-68b7-a0b1-368bb591c4d2@omp.ru> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: <34db8b96-624a-09e5-24e1-9b8be375a6c8@omp.ru> Date: Wed, 14 Sep 2022 20:30:42 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [31.173.80.79] X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 5.9.20, Database issued on: 09/14/2022 17:19:34 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 59 X-KSE-AntiSpam-Info: Lua profiles 172723 [Sep 14 2022] X-KSE-AntiSpam-Info: Version: 5.9.20.0 X-KSE-AntiSpam-Info: Envelope from: s.shtylyov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 498 498 840112829f78e8dd3e3ddbbff8b15d552f4973a3 X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: {relay has no DNS name} X-KSE-AntiSpam-Info: {SMTP from is not routable} X-KSE-AntiSpam-Info: {Found in DNSBL: 31.173.80.79 in (user) b.barracudacentral.org} X-KSE-AntiSpam-Info: {Found in DNSBL: 31.173.80.79 in (user) dbl.spamhaus.org} X-KSE-AntiSpam-Info: 127.0.0.199:7.1.2;omp.ru:7.1.1;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1 X-KSE-AntiSpam-Info: ApMailHostAddress: 31.173.80.79 X-KSE-AntiSpam-Info: {DNS response errors} X-KSE-AntiSpam-Info: Rate: 59 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 09/14/2022 17:23:00 X-KSE-AttachmentFiltering-Interceptor-Info: protection disabled X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 9/14/2022 2:00:00 PM X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 9/14/22 8:20 PM, Biju Das wrote: [...] >>> EMAC IP found on RZ/G2L Gb ethernet supports MII interface. >>> This patch adds support for selecting MII interface mode. >>> >>> Signed-off-by: Biju Das >>> --- >>> v2->v3: >>> * Documented CXR35_HALFCYC_CLKSW1000 and CXR35_SEL_XMII_MII macros. >> >> I definitely didn't mean it done this way... >> >> [...] >>> diff --git a/drivers/net/ethernet/renesas/ravb.h >>> b/drivers/net/ethernet/renesas/ravb.h >>> index b980bce763d3..058aceac8c92 100644 >>> --- a/drivers/net/ethernet/renesas/ravb.h >>> +++ b/drivers/net/ethernet/renesas/ravb.h >> [...] >>> @@ -965,6 +966,11 @@ enum CXR31_BIT { >>> CXR31_SEL_LINK1 = 0x00000008, >>> }; >>> >>> +enum CXR35_BIT { >>> + CXR35_HALFCYC_CLKSW1000 = 0x03E80000, /* 1000 cycle of clk_chi >> */ >> >> No, please just declare: > > >> >> CXR35_HALFCYC_CLKSW = 0xffff0000, > > Q1) Why do you think we should use this value for setting MII? Where are you seeing me asking for that? This is just the field declaration, correct against the manual... we can safely omit it as well... [...] >>> + CXR35_SEL_XMII_MII = 0x00000002, /* MII interface is used >> */ >> >> All the other register *enum*s are declared from LSB to MSB. The >> comment is pretty self-obvious here, please remove it. And declare the >> whole field too: >> >> CXR35_SEL_XMII = 0x00000003, > > Values 1 and 3 are reserved so we cannot use 3. Again, this is the filed declaration, correct against the manual... > I think the current patch holds good as per the hardware manual > for selecting MII interface. It is incomplete, compared against the manual. And declaring CXR35_HALFCYC_CLKSW1000 just looks completely ridiculous. :-) > Please recheck and correct me > if it is wrong. > Cheers, > Biju [...] MBR, Sergey