From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92CCFC433E1 for ; Wed, 27 May 2020 02:32:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7BA54207CB for ; Wed, 27 May 2020 02:32:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727117AbgE0CcK (ORCPT ); Tue, 26 May 2020 22:32:10 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:44830 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725267AbgE0CcK (ORCPT ); Tue, 26 May 2020 22:32:10 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id C8BF9F07DF5CA9384084; Wed, 27 May 2020 10:32:06 +0800 (CST) Received: from [127.0.0.1] (10.74.149.191) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.487.0; Wed, 27 May 2020 10:31:58 +0800 Subject: Re: [PATCH V2 net-next 0/2] net: hns3: adds two VLAN feature From: tanhuazhong To: David Miller , CC: , , , , References: <1590061105-36478-1-git-send-email-tanhuazhong@huawei.com> <20200521121707.6499ca6b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20200521.143726.481524442371246082.davem@davemloft.net> Message-ID: <356be994-7cf9-e7b2-8992-46a70bc6a54b@huawei.com> Date: Wed, 27 May 2020 10:31:59 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.74.149.191] X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2020/5/22 17:35, tanhuazhong wrote: > > > On 2020/5/22 5:37, David Miller wrote: >> From: Jakub Kicinski >> Date: Thu, 21 May 2020 12:17:07 -0700 >> >>> On Thu, 21 May 2020 19:38:23 +0800 Huazhong Tan wrote: >>>> This patchset adds two new VLAN feature. >>>> >>>> [patch 1] adds a new dynamic VLAN mode. >>>> [patch 2] adds support for 'QoS' field to PVID. >>>> >>>> Change log: >>>> V1->V2: modifies [patch 1]'s commit log, suggested by Jakub Kicinski. >>> >>> I don't like the idea that FW is choosing the driver behavior in a way >>> that's not observable via standard Linux APIs. This is the second time >>> a feature like that posted for a driver this week, and we should >>> discourage it. >> >> Agreed, this is an unacceptable approach to driver features. >> > > Hi, Jakub & David. > > As decribed in patch #1, there is a scenario which needs the dynamic > mode(port VLAN filter is always disabled, andVF VLAN filter is keep > disable until a non-zero VLAN ID being used for the function). > > Is this mode selection provided through "ethtool --set-priv-flags" > more acceptable? Or is there any other better suggestion for this? > > Thanks. > Hi, Jakub & David. For patch#1, is it acceptable adding "ethtool --get-priv-flags" to query the VLAN. If yes, I will send a RFC for it. Best Regards. Thanks. >> . >>