From: Florian Fainelli <f.fainelli@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>, David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
Vivien Didelot <vivien.didelot@gmail.com>
Subject: Re: [PATCH net-next 14/15] dsa: Allow tag drivers to be built as modules
Date: Fri, 19 Apr 2019 08:38:11 -0700 [thread overview]
Message-ID: <35ee991a-4862-995b-6f50-1312245c1c78@gmail.com> (raw)
In-Reply-To: <20190418023120.17067-15-andrew@lunn.ch>
On 4/17/2019 7:31 PM, Andrew Lunn wrote:
> Make the CONFIG symbols tristate and add help text.
>
> The broadcom and Microchip KSZ tag drivers support two different
> tagging protocols in one driver. Add a configuration option for the
> drivers, and then options to select the protocol.
>
> Create a submenu for the tagging drivers.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
[snip]
>
> -# tagging formats
> +config NET_DSA_TAG_BRCM_COMMON
> + tristate "Tag driver for Broadcom switch"
> + help
> + Say Y or M if you want to enable support for tagging frames
> + for the Broadcom switches.
The indentation between the tristate and help lines seems to be off a
little bit with spaces vs. tabs. This particular Kconfig symbol should
probably be hidden and selected by NET_DSA_TAG_BRCM and
NET_DSA_TAG_BRCM_PREPEND.
> +
> config NET_DSA_TAG_BRCM
> - bool
> + bool "Tag driver for Broadcom switch using in frame headers"
Plural: switches
> + depends on NET_DSA_TAG_BRCM_COMMON
> + help
> + Say Y if you want to enable support for tagging frames for the
> + Broadcom switches which place the tag after the MAC addresses.
After the MAC source address.
> +
>
> config NET_DSA_TAG_BRCM_PREPEND
> - bool
> + bool "Tag driver for Broadcom switches using prepended headers"
> + depends on NET_DSA_TAG_BRCM_COMMON
> + help
> + Say Y if you want to enable support for tagging frames for the
> + Broadcom switches which preprended headers.
Which places the tag before the Ethernet header (prepended).
--
Florian
next prev parent reply other threads:[~2019-04-19 18:22 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 2:31 [PATCH net-next 00/15] Make DSA tag drivers kernel modules Andrew Lunn
2019-04-18 2:31 ` [PATCH net-next 01/15] dsa: Add SPDX header to tag drivers Andrew Lunn
2019-04-18 17:35 ` Florian Fainelli
2019-04-18 2:31 ` [PATCH net-next 02/15] dsa: Move tagger name into its ops structure Andrew Lunn
2019-04-18 17:37 ` Florian Fainelli
2019-04-18 2:31 ` [PATCH net-next 03/15] dsa: Add MODULE_ALIAS to taggers in preperation to become modules Andrew Lunn
2019-04-19 15:25 ` Florian Fainelli
2019-04-18 2:31 ` [PATCH net-next 04/15] dsa: Add MODULE_LICENSE to tag drivers Andrew Lunn
2019-04-18 17:51 ` Florian Fainelli
2019-04-18 2:31 ` [PATCH net-next 05/15] dsa: Add TAG protocol to tag ops Andrew Lunn
2019-04-19 15:27 ` Florian Fainelli
2019-04-18 2:31 ` [PATCH net-next 06/15] dsa: Remove const from tag driver ops structure Andrew Lunn
2019-04-18 17:58 ` Florian Fainelli
2019-04-18 21:47 ` Andrew Lunn
2019-04-19 15:26 ` Florian Fainelli
2019-04-18 2:31 ` [PATCH net-next 07/15] dsa: Add boilerplate helper to register DSA tag driver modules Andrew Lunn
2019-04-19 15:29 ` Florian Fainelli
2019-04-18 2:31 ` [PATCH net-next 08/15] dsa: Keep link list of tag drivers Andrew Lunn
2019-04-18 7:25 ` David Miller
2019-04-18 9:35 ` Sergei Shtylyov
2019-04-18 13:19 ` Andrew Lunn
2019-04-18 14:40 ` Sergei Shtylyov
2019-04-19 15:30 ` Florian Fainelli
2019-04-18 2:31 ` [PATCH net-next 09/15] dsa: Register the none tagger ops Andrew Lunn
2019-04-19 15:31 ` Florian Fainelli
2019-04-18 2:31 ` [PATCH net-next 10/15] dsa: Rename dsa_resolve_tag_protocol() to _get ready for locking Andrew Lunn
2019-04-19 15:31 ` Florian Fainelli
2019-04-18 2:31 ` [PATCH net-next 11/15] dsa: Add stub tag driver put method Andrew Lunn
2019-04-19 15:32 ` Florian Fainelli
2019-04-18 2:31 ` [PATCH net-next 12/15] dsa: Make use of the list of tag drivers Andrew Lunn
2019-04-19 15:33 ` Florian Fainelli
2019-04-18 2:31 ` [PATCH net-next 13/15] dsa: Cleanup unneeded table and make tag structures static Andrew Lunn
2019-04-19 15:34 ` Florian Fainelli
2019-04-18 2:31 ` [PATCH net-next 14/15] dsa: Allow tag drivers to be built as modules Andrew Lunn
2019-04-19 15:38 ` Florian Fainelli [this message]
2019-04-18 2:31 ` [PATCH net-next 15/15] dsa: tag_brcm: Avoid unused symbols Andrew Lunn
2019-04-19 15:39 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35ee991a-4862-995b-6f50-1312245c1c78@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).