From: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
To: Eric Dumazet <eric.dumazet@gmail.com>,
"jon.maloy@ericsson.com" <jon.maloy@ericsson.com>,
"ying.xue@windriver.com" <ying.xue@windriver.com>,
"davem@davemloft.net" <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"tipc-discussion@lists.sourceforge.net"
<tipc-discussion@lists.sourceforge.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tipc: ensure skb->lock is initialised
Date: Mon, 8 Jul 2019 20:43:47 +0000 [thread overview]
Message-ID: <361940337b0d4833a5634ddd1e1896a9@svr-chch-ex1.atlnz.lc> (raw)
In-Reply-To: 2298b9eb-100f-6130-60c4-0e5e2c7b84d1@gmail.com
On 8/07/19 8:18 PM, Eric Dumazet wrote:
>
>
> On 7/8/19 12:53 AM, Chris Packham wrote:
>> tipc_named_node_up() creates a skb list. It passes the list to
>> tipc_node_xmit() which has some code paths that can call
>> skb_queue_purge() which relies on the list->lock being initialised.
>> Ensure tipc_named_node_up() uses skb_queue_head_init() so that the lock
>> is explicitly initialised.
>>
>> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
>
> I would rather change the faulty skb_queue_purge() to __skb_queue_purge()
>
Makes sense. I'll look at that for v2.
next prev parent reply other threads:[~2019-07-08 20:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-07 22:53 [PATCH] tipc: ensure skb->lock is initialised Chris Packham
2019-07-08 8:18 ` Eric Dumazet
2019-07-08 20:43 ` Chris Packham [this message]
2019-07-08 21:13 ` Chris Packham
2019-07-09 7:30 ` Eric Dumazet
2019-07-09 13:25 ` Jon Maloy
2019-07-09 13:45 ` Eric Dumazet
2019-07-09 20:15 ` Jon Maloy
2019-07-10 8:00 ` Eric Dumazet
2019-07-10 13:10 ` Jon Maloy
2019-07-10 20:58 ` Chris Packham
2019-07-11 12:55 ` Jon Maloy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=361940337b0d4833a5634ddd1e1896a9@svr-chch-ex1.atlnz.lc \
--to=chris.packham@alliedtelesis.co.nz \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jon.maloy@ericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).