netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Igor Russkikh <Igor.Russkikh@aquantia.com>
To: "David S . Miller" <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Igor Russkikh <Igor.Russkikh@aquantia.com>
Subject: [PATCH net-next v3 1/8] net: aquantia: replace internal driver version code with uts
Date: Wed, 26 Jun 2019 12:35:33 +0000	[thread overview]
Message-ID: <3626643576c39a54edea6f7ba09626f44951a9f9.1561552290.git.igor.russkikh@aquantia.com> (raw)
In-Reply-To: <cover.1561552290.git.igor.russkikh@aquantia.com>

As it was discussed some time previously, driver is better to
report kernel version string, as it in a best way identifies
the codebase.

Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
 drivers/net/ethernet/aquantia/atlantic/aq_cfg.h | 7 +++----
 drivers/net/ethernet/aquantia/atlantic/ver.h    | 5 -----
 2 files changed, 3 insertions(+), 9 deletions(-)

diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_cfg.h b/drivers/net/ethernet/aquantia/atlantic/aq_cfg.h
index 173be45463ee..02f1b70c4e25 100644
--- a/drivers/net/ethernet/aquantia/atlantic/aq_cfg.h
+++ b/drivers/net/ethernet/aquantia/atlantic/aq_cfg.h
@@ -9,6 +9,8 @@
 #ifndef AQ_CFG_H
 #define AQ_CFG_H
 
+#include <generated/utsrelease.h>
+
 #define AQ_CFG_VECS_DEF   8U
 #define AQ_CFG_TCS_DEF    1U
 
@@ -86,10 +88,7 @@
 #define AQ_CFG_DRV_AUTHOR      "aQuantia"
 #define AQ_CFG_DRV_DESC        "aQuantia Corporation(R) Network Driver"
 #define AQ_CFG_DRV_NAME        "atlantic"
-#define AQ_CFG_DRV_VERSION	__stringify(NIC_MAJOR_DRIVER_VERSION)"."\
-				__stringify(NIC_MINOR_DRIVER_VERSION)"."\
-				__stringify(NIC_BUILD_DRIVER_VERSION)"."\
-				__stringify(NIC_REVISION_DRIVER_VERSION) \
+#define AQ_CFG_DRV_VERSION	UTS_RELEASE \
 				AQ_CFG_DRV_VERSION_SUFFIX
 
 #endif /* AQ_CFG_H */
diff --git a/drivers/net/ethernet/aquantia/atlantic/ver.h b/drivers/net/ethernet/aquantia/atlantic/ver.h
index 23374bffa92b..597654b51e01 100644
--- a/drivers/net/ethernet/aquantia/atlantic/ver.h
+++ b/drivers/net/ethernet/aquantia/atlantic/ver.h
@@ -7,11 +7,6 @@
 #ifndef VER_H
 #define VER_H
 
-#define NIC_MAJOR_DRIVER_VERSION           2
-#define NIC_MINOR_DRIVER_VERSION           0
-#define NIC_BUILD_DRIVER_VERSION           4
-#define NIC_REVISION_DRIVER_VERSION        0
-
 #define AQ_CFG_DRV_VERSION_SUFFIX "-kern"
 
 #endif /* VER_H */
-- 
2.17.1


  reply	other threads:[~2019-06-26 12:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-26 12:35 [PATCH net-next v3 0/8] net: aquantia: implement vlan offloads Igor Russkikh
2019-06-26 12:35 ` Igor Russkikh [this message]
2019-06-26 12:35 ` [PATCH net-next v3 2/8] net: aquantia: add documentation for the atlantic driver Igor Russkikh
2019-06-26 12:35 ` [PATCH net-next v3 3/8] maintainers: declare aquantia atlantic driver maintenance Igor Russkikh
2019-06-26 12:35 ` [PATCH net-next v3 4/8] net: aquantia: make all files GPL-2.0-only Igor Russkikh
2019-06-26 12:35 ` [PATCH net-next v3 5/8] net: aquantia: added vlan offload related macros and functions Igor Russkikh
2019-06-26 12:35 ` [PATCH net-next v3 6/8] net: aquantia: adding fields and device features for vlan offload Igor Russkikh
2019-06-26 12:35 ` [PATCH net-next v3 7/8] net: aquantia: vlan offloads logic in datapath Igor Russkikh
2019-06-26 12:35 ` [PATCH net-next v3 8/8] net: aquantia: implement vlan offload configuration Igor Russkikh
2019-06-26 16:26 ` [PATCH net-next v3 0/8] net: aquantia: implement vlan offloads David Miller
2019-06-27 17:58 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3626643576c39a54edea6f7ba09626f44951a9f9.1561552290.git.igor.russkikh@aquantia.com \
    --to=igor.russkikh@aquantia.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).