From: Daniel Borkmann <daniel@iogearbox.net>
To: Zwb <ethercflow@gmail.com>, netdev@vger.kernel.org
Cc: yhs@fb.com
Subject: Re: [PATCH bpf-next] bpf: add new helper fd2path for mapping a file descriptor to a pathname
Date: Thu, 17 Oct 2019 16:49:48 +0200 [thread overview]
Message-ID: <365b18db-cf7f-1d1d-f048-7220eb702e8f@iogearbox.net> (raw)
In-Reply-To: <20191017092631.3739-1-ethercflow@gmail.com>
On 10/17/19 11:26 AM, Zwb wrote:
> When people want to identify which file system files are being opened,
> read, and written to, they can use this helper with file descriptor as
> input to achieve this goal. Other pseudo filesystems are also supported.
>
> Signed-off-by: Zwb <ethercflow@gmail.com>
SOB requires that there is a proper name, see Documentation/process/submitting-patches.rst +431.
[...]
> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
> index a65c3b0c6935..a4a5d432e572 100644
> --- a/include/uapi/linux/bpf.h
> +++ b/include/uapi/linux/bpf.h
> @@ -2769,6 +2769,7 @@ union bpf_attr {
> FN(get_current_pid_tgid), \
> FN(get_current_uid_gid), \
> FN(get_current_comm), \
> + FN(fd2path), \
Adding into the middle will break existing BPF programs. Helper description is also missing.
> FN(get_cgroup_classid), \
> FN(skb_vlan_push), \
> FN(skb_vlan_pop), \
next prev parent reply other threads:[~2019-10-17 14:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 9:26 [PATCH bpf-next] bpf: add new helper fd2path for mapping a file descriptor to a pathname Zwb
2019-10-17 14:49 ` Daniel Borkmann [this message]
2019-10-18 16:07 ` Yonghong Song
2019-10-18 10:47 Wenbo Zhang
2019-10-18 18:20 ` Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=365b18db-cf7f-1d1d-f048-7220eb702e8f@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ethercflow@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).