From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F2E8C433B4 for ; Tue, 20 Apr 2021 21:28:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 053F0613FC for ; Tue, 20 Apr 2021 21:28:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234166AbhDTV2m convert rfc822-to-8bit (ORCPT ); Tue, 20 Apr 2021 17:28:42 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:5138 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233724AbhDTV2l (ORCPT ); Tue, 20 Apr 2021 17:28:41 -0400 Received: from DGGEML402-HUB.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4FPxYv5wzNzYVxM; Wed, 21 Apr 2021 05:25:55 +0800 (CST) Received: from dggpeml100022.china.huawei.com (7.185.36.176) by DGGEML402-HUB.china.huawei.com (10.3.17.38) with Microsoft SMTP Server (TLS) id 14.3.498.0; Wed, 21 Apr 2021 05:28:06 +0800 Received: from lhreml703-chm.china.huawei.com (10.201.108.52) by dggpeml100022.china.huawei.com (7.185.36.176) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Wed, 21 Apr 2021 05:28:05 +0800 Received: from lhreml703-chm.china.huawei.com ([10.201.68.198]) by lhreml703-chm.china.huawei.com ([10.201.68.198]) with mapi id 15.01.2176.012; Tue, 20 Apr 2021 22:28:03 +0100 From: Salil Mehta To: "Brelinski, TonyX" , "davem@davemloft.net" , "kuba@kernel.org" CC: "linuxarm@openeuler.org" , "netdev@vger.kernel.org" , Linuxarm , "linux-kernel@vger.kernel.org" , Jeff Kirsher , "intel-wired-lan@lists.osuosl.org" Subject: RE: [Intel-wired-lan] [PATCH V2 net] ice: Re-organizes reqstd/avail {R, T}XQ check/code for efficiency+readability Thread-Topic: [Intel-wired-lan] [PATCH V2 net] ice: Re-organizes reqstd/avail {R, T}XQ check/code for efficiency+readability Thread-Index: AQHXNiN2hWkBr07qTEeNIfBhJLjN3qq9612A Date: Tue, 20 Apr 2021 21:28:03 +0000 Message-ID: <3779ba631def46ddaa1fc90d8d6b47a5@huawei.com> References: <20210413224446.16612-1-salil.mehta@huawei.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.47.76.38] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > From: Brelinski, TonyX [mailto:tonyx.brelinski@intel.com] > Sent: Tuesday, April 20, 2021 9:26 PM > > > From: Intel-wired-lan On Behalf Of > > Salil Mehta > > Sent: Tuesday, April 13, 2021 3:45 PM > > To: davem@davemloft.net; kuba@kernel.org > > Cc: salil.mehta@huawei.com; linuxarm@openeuler.org; > > netdev@vger.kernel.org; linuxarm@huawei.com; linux- > > kernel@vger.kernel.org; Jeff Kirsher ; intel- > > wired-lan@lists.osuosl.org > > Subject: [Intel-wired-lan] [PATCH V2 net] ice: Re-organizes reqstd/avail {R, > > T}XQ check/code for efficiency+readability > > > > If user has explicitly requested the number of {R,T}XQs, then it is > > unnecessary to get the count of already available {R,T}XQs from the PF > > avail_{r,t}xqs bitmap. This value will get overridden by user specified value > in > > any case. > > > > This patch does minor re-organization of the code for improving the flow and > > readabiltiy. This scope of improvement was found during the review of the > > ICE driver code. > > > > FYI, I could not test this change due to unavailability of the hardware. > > It would be helpful if somebody can test this patch and provide Tested-by > > Tag. Many thanks! > > > > Fixes: 87324e747fde ("ice: Implement ethtool ops for channels") > > Cc: intel-wired-lan@lists.osuosl.org > > Cc: Jeff Kirsher > > Signed-off-by: Salil Mehta > > -- > > Change V1->V2 > > (*) Fixed the comments from Anthony Nguyen(Intel) > > Link: https://lkml.org/lkml/2021/4/12/1997 > > --- > > drivers/net/ethernet/intel/ice/ice_lib.c | 14 ++++++++------ > > 1 file changed, 8 insertions(+), 6 deletions(-) > > Tested-by: Tony Brelinski (A Contingent Worker at > Intel) Many thanks! Salil.