netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brett Creeley <bcreeley@amd.com>
To: Erwan Velu <e.velu@criteo.com>,
	Tony Nguyen <anthony.l.nguyen@intel.com>,
	Erwan Velu <erwanaliasr1@gmail.com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 iwl-net] i40e: Prevent setting MTU if greater than MFS
Date: Fri, 15 Mar 2024 09:19:22 -0700	[thread overview]
Message-ID: <3802fb51-c419-4b8a-95a1-da605493505d@amd.com> (raw)
In-Reply-To: <4cd04119-8a93-4304-b1ce-88110788c8ef@criteo.com>



On 3/15/2024 2:17 AM, Erwan Velu wrote:
> Caution: This message originated from an External Source. Use proper 
> caution when opening attachments, clicking links, or responding.
> 
> 
> Le 14/03/2024 à 21:31, Tony Nguyen a écrit :
>> [..]
>> Setting the mfs size to max values during init and reset would better;
>> this is what the ice driver does. However, this would take
>> implementing new AdminQ calls. IMO this patch is ok to prevent the
>> issue being reported and allow for ease of backport.
>>
> That was my first intention, ensure that no one else get stuck in the
> same situation.
> 
> It would be nice to backport it to all stable releases once merged.
> 
> Erwan,
> 

I'm okay with this approach. Thanks.

Brett

  reply	other threads:[~2024-03-15 16:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-13  9:07 [PATCH v4 iwl-net] i40e: Prevent setting MTU if greater than MFS Erwan Velu
2024-03-14 16:10 ` Brett Creeley
2024-03-14 17:10   ` Erwan Velu
2024-03-14 17:55     ` Brett Creeley
2024-03-14 18:04       ` Erwan Velu
2024-03-14 20:31         ` Tony Nguyen
2024-03-15  9:17           ` Erwan Velu
2024-03-15 16:19             ` Brett Creeley [this message]
2024-03-18 17:45 ` Simon Horman
2024-03-19 10:26   ` Sunil Kovvuri Goutham
     [not found]   ` <d33b98de-dfc0-445e-bdd7-0ae76d050ed4@criteo.com>
2024-03-19 12:20     ` Simon Horman
2024-03-19 13:33       ` Erwan Velu
2024-04-19 14:26 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
     [not found]   ` <CAL2JzuxraP5xCxt4_EK3zbz9kyAyxJFuEadtq4zHsdMjR5PGTw@mail.gmail.com>
2024-04-22 13:19     ` Pucha, HimasekharX Reddy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3802fb51-c419-4b8a-95a1-da605493505d@amd.com \
    --to=bcreeley@amd.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=e.velu@criteo.com \
    --cc=edumazet@google.com \
    --cc=erwanaliasr1@gmail.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jesse.brandeburg@intel.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).