From: Jason Wang <jasowang@redhat.com>
To: Radu Rendec <rrendec@arista.com>,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: virtio_net: ethtool supported link modes
Date: Fri, 1 Sep 2017 11:36:01 +0800 [thread overview]
Message-ID: <38286395-683f-f285-aaa5-68f0e8b68675@redhat.com> (raw)
In-Reply-To: <1504199044.22080.11.camel@arista.com>
On 2017年09月01日 01:04, Radu Rendec wrote:
> Hello,
>
> Looking at the code in virtnet_set_link_ksettings, it seems the speed
> and duplex can be set to any valid value. The driver will "remember"
> them and report them back in virtnet_get_link_ksettings.
>
> However, the supported link modes (link_modes.supported in struct
> ethtool_link_ksettings) is always 0, indicating that no speed/duplex
> setting is supported.
>
> Does it make more sense to set (at least a few of) the supported link
> modes, such as 10baseT_Half ... 10000baseT_Full?
>
> I would expect to see consistency between what is reported in
> link_modes.supported and what can actually be set. Could you please
> share your opinion on this?
I think the may make sense only if there's a hardware implementation for
virtio. And we probably need to extend virtio spec for adding new commands.
Thanks
>
> Thank you,
> Radu Rendec
>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2017-09-01 3:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 17:04 virtio_net: ethtool supported link modes Radu Rendec
2017-09-01 3:36 ` Jason Wang [this message]
2017-09-01 12:01 ` Radu Rendec
2017-09-01 15:43 ` Michael S. Tsirkin
2017-09-01 16:19 ` Radu Rendec
2017-09-01 17:45 ` Michael S. Tsirkin
2017-09-04 14:59 ` Radu Rendec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38286395-683f-f285-aaa5-68f0e8b68675@redhat.com \
--to=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rrendec@arista.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).