netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hayes Wang <hayeswang@realtek.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>,
	"davem@davemloft.net" <davem@davemloft.net>
Cc: Jakub Kicinski <jakub.kicinski@netronome.com>,
	Prashant Malani <pmalani@chromium.org>,
	Grant Grundler <grundler@chromium.org>,
	"Mario Limonciello" <mario.limonciello@dell.com>,
	David Chen <david.chen7@dell.com>,
	"open list:USB NETWORKING DRIVERS" <linux-usb@vger.kernel.org>,
	"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] r8152: Add MAC passthrough support to new device
Date: Wed, 15 Jan 2020 06:19:04 +0000	[thread overview]
Message-ID: <383516f7b54247bda694bf2a999e68f7@realtek.com> (raw)
In-Reply-To: <20200114044127.20085-1-kai.heng.feng@canonical.com>

Kai-Heng Feng [mailto:kai.heng.feng@canonical.com]
> Sent: Tuesday, January 14, 2020 12:41 PM
[...]
>  	if (le16_to_cpu(udev->descriptor.idVendor) == VENDOR_ID_LENOVO &&
> -	    le16_to_cpu(udev->descriptor.idProduct) == 0x3082)
> +	    (le16_to_cpu(udev->descriptor.idProduct) == 0x3082 ||
> +	     le16_to_cpu(udev->descriptor.idProduct) == 0xa387))

How about using
switch (le16_to_cpu(udev->descriptor.idProduct)) {
...
}

>  		set_bit(LENOVO_MACPASSTHRU, &tp->flags);
> 
>  	if (le16_to_cpu(udev->descriptor.bcdDevice) == 0x3011 && udev->serial
> &&
> --
> 2.17.1


Best Regards,
Hayes



      parent reply	other threads:[~2020-01-15  6:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-14  4:41 [PATCH] r8152: Add MAC passthrough support to new device Kai-Heng Feng
2020-01-14  7:51 ` Prashant Malani
2020-01-14  8:03   ` Kai-Heng Feng
2020-01-14  8:23 ` Oliver Neukum
2020-01-14  9:22   ` Kai-Heng Feng
2020-01-14 20:33 ` Mario.Limonciello
2020-01-15  6:40   ` Kai Heng Feng
2020-01-15  7:04     ` Hayes Wang
2020-01-15  6:19 ` Hayes Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=383516f7b54247bda694bf2a999e68f7@realtek.com \
    --to=hayeswang@realtek.com \
    --cc=davem@davemloft.net \
    --cc=david.chen7@dell.com \
    --cc=grundler@chromium.org \
    --cc=jakub.kicinski@netronome.com \
    --cc=kai.heng.feng@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mario.limonciello@dell.com \
    --cc=netdev@vger.kernel.org \
    --cc=pmalani@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).