From: "Samudrala, Sridhar" <sridhar.samudrala@intel.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: mst@redhat.com, stephen@networkplumber.org, davem@davemloft.net,
netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org,
virtio-dev@lists.oasis-open.org, jesse.brandeburg@intel.com,
alexander.h.duyck@intel.com, kubakici@wp.pl, jasowang@redhat.com,
loseweigh@gmail.com, aaron.f.brown@intel.com,
anjali.singhai@intel.com
Subject: Re: [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework
Date: Tue, 22 May 2018 08:28:42 -0700 [thread overview]
Message-ID: <39081bce-3913-5b07-3d07-0c476fca5e78@intel.com> (raw)
In-Reply-To: <20180522090853.GF2149@nanopsycho>
On 5/22/2018 2:08 AM, Jiri Pirko wrote:
> Tue, May 22, 2018 at 11:06:37AM CEST, jiri@resnulli.us wrote:
>> Tue, May 22, 2018 at 04:06:18AM CEST, sridhar.samudrala@intel.com wrote:
>>> Use the registration/notification framework supported by the generic
>>> failover infrastructure.
>>>
>>> Signed-off-by: Sridhar Samudrala <sridhar.samudrala@intel.com>
>> In previous patchset versions, the common code did
>> netdev_rx_handler_register() and netdev_upper_dev_link() etc
>> (netvsc_vf_join()). Now, this is still done in netvsc. Why?
>>
>> This should be part of the common "failover" code.
Based on Stephen's feedback on earlier patches, i tried to minimize the changes to
netvsc and only commonize the notifier and the main event handler routine.
Another complication is that netvsc does part of registration in a delayed workqueue.
It should be possible to move some of the code from net_failover.c to generic
failover.c in future if Stephen is ok with it.
>>
> Also note that in the current patchset you use IFF_FAILOVER flag for
> master, yet for the slave you use IFF_SLAVE. That is wrong.
> IFF_FAILOVER_SLAVE should be used.
Not sure which code you are referring to. I only set IFF_FAILOVER_SLAVE
in patch 3.
next prev parent reply other threads:[~2018-05-22 15:28 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 2:06 [PATCH net-next v11 0/5] Enable virtio_net to act as a standby for a passthru device Sridhar Samudrala
2018-05-22 2:06 ` [PATCH net-next v11 1/5] net: Introduce generic failover module Sridhar Samudrala
2018-05-22 2:06 ` [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework Sridhar Samudrala
2018-05-22 9:06 ` Jiri Pirko
2018-05-22 9:08 ` Jiri Pirko
2018-05-22 13:12 ` Michael S. Tsirkin
2018-05-22 13:14 ` Jiri Pirko
2018-05-22 13:17 ` Michael S. Tsirkin
2018-05-22 13:26 ` Jiri Pirko
2018-05-22 13:39 ` Michael S. Tsirkin
2018-05-22 15:13 ` Jiri Pirko
2018-05-22 15:32 ` Michael S. Tsirkin
2018-05-22 15:45 ` Jiri Pirko
2018-05-22 16:52 ` Michael S. Tsirkin
2018-05-22 17:38 ` Jiri Pirko
2018-05-22 19:54 ` Michael S. Tsirkin
2018-05-22 15:28 ` Samudrala, Sridhar [this message]
2018-05-22 15:36 ` Shepherd request (P83): Multipath TCP: Present Use Cases and an Upstream Future Jiri Pirko
2018-05-22 15:46 ` Michael S. Tsirkin
2018-05-22 16:12 ` [PATCH net-next v11 2/5] netvsc: refactor notifier/event handling code to use the failover framework Jiri Pirko
2018-05-22 20:54 ` Samudrala, Sridhar
2018-05-23 6:27 ` Jiri Pirko
2018-05-23 16:16 ` Samudrala, Sridhar
2018-05-22 2:06 ` [PATCH net-next v11 3/5] net: Introduce net_failover driver Sridhar Samudrala
2018-05-22 8:59 ` Jiri Pirko
2018-05-22 2:06 ` [PATCH net-next v11 4/5] virtio_net: Introduce VIRTIO_NET_F_STANDBY feature bit Sridhar Samudrala
2018-05-22 2:06 ` [PATCH net-next v11 5/5] virtio_net: Extend virtio to use VF datapath when available Sridhar Samudrala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39081bce-3913-5b07-3d07-0c476fca5e78@intel.com \
--to=sridhar.samudrala@intel.com \
--cc=aaron.f.brown@intel.com \
--cc=alexander.h.duyck@intel.com \
--cc=anjali.singhai@intel.com \
--cc=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=jesse.brandeburg@intel.com \
--cc=jiri@resnulli.us \
--cc=kubakici@wp.pl \
--cc=loseweigh@gmail.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).