Netdev Archive on lore.kernel.org
 help / color / Atom feed
From: "Li,Rongqing" <lirongqing@baidu.com>
To: Yunsheng Lin <linyunsheng@huawei.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"saeedm@mellanox.com" <saeedm@mellanox.com>
Subject: 答复: 答复: 答复: 答复: 答复: [PATCH] page_pool: mark unbound node page as reusable pages
Date: Thu, 5 Dec 2019 03:18:22 +0000
Message-ID: <3a0d273cb57146d3b2f5c849569fb244@baidu.com> (raw)
In-Reply-To: <0c5b19c3-b639-b990-73a1-a1300d417221@huawei.com>


> >> [1] https://lore.kernel.org/patchwork/patch/1125789/
> >
> >
> > What is status of this patch? I think you should fix your firmware or
> > bios
> 
> Have not reached a conclusion yet.

I think it will never be accepted

> 
> >
> > Consider the below condition:
> >
> > there is two numa node, and NIC sites on node 2, but NUMA_NO_NODE is
> > used, recycle will fail due to page_to_nid(page) == numa_mem_id(), and
> reallocated pages maybe always from node 1, then the recycle will never
> success.
> 
> For page pool:
> 
> 1. if the pool->p.nid != NUMA_NO_NODE, the recycle is always decided by
> checking page_to_nid(page) == pool->p.nid.
> 
> 2. only when the pool->p.nid == NUMA_NO_NODE, the numa_mem_id() is
> checked
>    to decide the recycle.
> 
> Yes, If pool->p.nid == NUMA_NO_NODE, and the cpu that is doing recycling is
> changing each time, the recycle may never success, but it is not common, 

Why can we ignore this condition, and accept your hardware with abnormal node
information

>and
> have its own performance penalty when changing the recycling cpu so often.

I have said if hardware takes care of numa node, it should be assign when page pool
Is created, not depends on recycle.

If you insist your idea, you can submit you patch after this one

-RongQing

> 
> 
> >
> > -RongQing
> >
> >


  reply index

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-04 10:14 Li RongQing
2019-12-05  0:55 ` Yunsheng Lin
2019-12-05  1:08   ` 答复: " Li,Rongqing
2019-12-05  1:43     ` Yunsheng Lin
2019-12-05  1:55       ` 答复: " Li,Rongqing
2019-12-05  2:06         ` Yunsheng Lin
2019-12-05  2:17           ` 答复: " Li,Rongqing
2019-12-05  2:30             ` Yunsheng Lin
2019-12-05  2:47               ` 答复: " Li,Rongqing
2019-12-05  3:03                 ` Yunsheng Lin
2019-12-05  3:18                   ` Li,Rongqing [this message]
2019-12-05  3:33                     ` 答复: " Yunsheng Lin
2019-12-06  8:05                       ` 答复: " Li,Rongqing
2019-12-05  1:22   ` Li,Rongqing

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3a0d273cb57146d3b2f5c849569fb244@baidu.com \
    --to=lirongqing@baidu.com \
    --cc=linyunsheng@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=saeedm@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Netdev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git
	git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \
		netdev@vger.kernel.org
	public-inbox-index netdev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netdev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git