From: Jiri Slaby <jslaby@suse.cz>
To: Ben Hutchings <ben.hutchings@codethink.co.uk>,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>
Cc: stable@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4.4 18/31] r8152: napi hangup fix after disconnect
Date: Sat, 25 Aug 2018 09:43:23 +0200 [thread overview]
Message-ID: <3b118091-d600-0be8-3204-c0f794ef6288@suse.cz> (raw)
In-Reply-To: <1535128726.2902.32.camel@codethink.co.uk>
On 08/24/2018, 06:38 PM, Ben Hutchings wrote:
> On Fri, 2018-07-20 at 14:13 +0200, Greg Kroah-Hartman wrote:
>> 4.4-stable review patch. If anyone has any objections, please let me know.
>>
>> ------------------
>>
>> From: Jiri Slaby <jslaby@suse.cz>
>>
>> [ Upstream commit 0ee1f4734967af8321ecebaf9c74221ace34f2d5 ]
> [...]
>> --- a/drivers/net/usb/r8152.c
>> +++ b/drivers/net/usb/r8152.c
>> @@ -3139,7 +3139,8 @@ static int rtl8152_close(struct net_devi
>> #ifdef CONFIG_PM_SLEEP
>> unregister_pm_notifier(&tp->pm_notifier);
>> #endif
>> - napi_disable(&tp->napi);
>> + if (!test_bit(RTL8152_UNPLUG, &tp->flags))
>> + napi_disable(&tp->napi);
>> clear_bit(WORK_ENABLE, &tp->flags);
>> usb_kill_urb(tp->intr_urb);
>> cancel_delayed_work_sync(&tp->schedule);
>
> This flag appears to be set only if the USB device is actually
> disconnected. In case the driver is unbound for some other reason
> (like the module is removed), the same problem will occur.
Could you elaborate? I thought this would happen:
module_exit -> usb_deregister -> usb_unbind_device -> rtl8152_disconnect
-> unregister_netdev -> rtl8152_close
Am I missing something?
thanks,
--
js
suse labs
next prev parent reply other threads:[~2018-08-25 7:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180720121340.158484922@linuxfoundation.org>
2018-07-20 12:13 ` [PATCH 4.4 18/31] r8152: napi hangup fix after disconnect Greg Kroah-Hartman
2018-08-24 16:38 ` Ben Hutchings
2018-08-25 7:43 ` Jiri Slaby [this message]
2018-09-12 18:54 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b118091-d600-0be8-3204-c0f794ef6288@suse.cz \
--to=jslaby@suse.cz \
--cc=ben.hutchings@codethink.co.uk \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).