From: Heiner Kallweit <hkallweit1@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
David Miller <davem@davemloft.net>,
Robert Hancock <hancock@sedsystems.ca>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net: phy: add flag PHY_QUIRK_NO_ESTATEN
Date: Tue, 4 Jun 2019 23:07:09 +0200 [thread overview]
Message-ID: <3b926b01-4473-f070-056f-75bf3cd49a74@gmail.com> (raw)
In-Reply-To: <20190604130049.GA16951@lunn.ch>
On 04.06.2019 15:00, Andrew Lunn wrote:
> On Tue, Jun 04, 2019 at 08:10:50AM +0200, Heiner Kallweit wrote:
>> We have a Xilinx GBit PHY that doesn't have BMSR_ESTATEN set
>> (what violates the Clause 22 standard). Instead of having the PHY
>> driver to implement almost identical copies of few generic functions
>> let's add a flag for this quirk to phylib.
>
> Hi Heiner
>
> It is a bit of a personal preference, but i would prefer the Xilinx
> driver worked around broken hardware, not scatter quirks in the core.
> Keep the core clean.
>
> If we had multiple PHYs broken in the same way, then maybe a quirk.
>
Yes, I was expecting that there may be different opinions on whether
this should be handled in the core or by the driver.
But this is obsolete now anyway after Robert figured out that his
problem actually was another one.
> Andrew
>
Heiner
prev parent reply other threads:[~2019-06-04 21:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 6:10 [PATCH net-next] net: phy: add flag PHY_QUIRK_NO_ESTATEN Heiner Kallweit
2019-06-04 13:00 ` Andrew Lunn
2019-06-04 21:07 ` Heiner Kallweit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b926b01-4473-f070-056f-75bf3cd49a74@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hancock@sedsystems.ca \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).