From: David Ahern <dsahern@kernel.org>
To: "Xiao, Jiguang" <Jiguang.Xiao@windriver.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"yoshfuji@linux-ipv6.org" <yoshfuji@linux-ipv6.org>,
"kuba@kernel.org" <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "Pudak, Filip" <Filip.Pudak@windriver.com>
Subject: Re: This counter "ip6InNoRoutes" does not follow the RFC4293 specification implementation
Date: Tue, 8 Mar 2022 21:50:01 -0700 [thread overview]
Message-ID: <3f6540b8-aeab-02f8-27bc-d78c9eba588c@kernel.org> (raw)
In-Reply-To: <SJ0PR11MB51209DA3F7CAAB45A609633A930A9@SJ0PR11MB5120.namprd11.prod.outlook.com>
On 3/8/22 7:16 PM, Xiao, Jiguang wrote:
> Hi David
>
> To confirm whether my test method is correct, could you please briefly describe your test procedure?
>
>
>
no formal test. Code analysis (ip6_pkt_discard{,_out} -> ip6_pkt_drop)
shows the counters that should be incrementing and then looking at the
counters on a local server.
FIB Lookup failures should generate a dst with one of these handlers:
static void ip6_rt_init_dst_reject(struct rt6_info *rt, u8 fib6_type)
{
rt->dst.error = ip6_rt_type_to_error(fib6_type);
switch (fib6_type) {
case RTN_BLACKHOLE:
rt->dst.output = dst_discard_out;
rt->dst.input = dst_discard;
break;
case RTN_PROHIBIT:
rt->dst.output = ip6_pkt_prohibit_out;
rt->dst.input = ip6_pkt_prohibit;
break;
case RTN_THROW:
case RTN_UNREACHABLE:
default:
rt->dst.output = ip6_pkt_discard_out;
rt->dst.input = ip6_pkt_discard;
break;
}
}
They all drop the packet with a given counter bumped.
next prev parent reply other threads:[~2022-03-09 4:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <SJ0PR11MB51207CBDB5145A89B8A0A15393359@SJ0PR11MB5120.namprd11.prod.outlook.com>
[not found] ` <SJ0PR11MB51202FA2365341740048A64593359@SJ0PR11MB5120.namprd11.prod.outlook.com>
[not found] ` <SJ0PR11MB51209200786235187572EE0D93359@SJ0PR11MB5120.namprd11.prod.outlook.com>
[not found] ` <SJ0PR11MB5120426D474963E08936DD2493359@SJ0PR11MB5120.namprd11.prod.outlook.com>
2022-02-17 2:59 ` This counter "ip6InNoRoutes" does not follow the RFC4293 specification implementation David Ahern
2022-02-24 9:04 ` Xiao, Jiguang
2022-03-09 2:16 ` Xiao, Jiguang
2022-03-09 4:50 ` David Ahern [this message]
2022-03-31 9:13 ` Pudak, Filip
2022-03-31 14:13 ` David Ahern
2022-04-04 7:09 ` Pudak, Filip
2022-04-04 15:09 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f6540b8-aeab-02f8-27bc-d78c9eba588c@kernel.org \
--to=dsahern@kernel.org \
--cc=Filip.Pudak@windriver.com \
--cc=Jiguang.Xiao@windriver.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).