From: Harald Mommer <hmo@opensynergy.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
Harald Mommer <harald.mommer@opensynergy.com>
Cc: virtio-dev@lists.oasis-open.org, linux-can@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Wolfgang Grandegger <wg@grandegger.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Dariusz Stojaczyk <Dariusz.Stojaczyk@opensynergy.com>
Subject: Re: [RFC PATCH 1/1] can: virtio: Initial virtio CAN driver.
Date: Thu, 3 Nov 2022 14:55:49 +0100 [thread overview]
Message-ID: <40e3d678-b840-e780-c1da-367000724f69@opensynergy.com> (raw)
In-Reply-To: <20220827093909.ag3zi7k525k4zuqq@pengutronix.de>
Hello,
On 27.08.22 11:39, Marc Kleine-Budde wrote:
> Is there an Open Source implementation of the host side of this
> interface?
there is neither an open source device nor is it currently planned. The
device I'm developing is closed source.
> Please fix these checkpatch warnings:
>
> | WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> | #65:
> | new file mode 100644
> |
Addressed most of the checkpatch warnings. Regarding the BUG_ON()
minimized usage. Removed where not necessary, reworked where a better
error handling was possible, kept where I don't think it will catch ever
but if it catches I would like to know. Of course I could make the tool
happy but on the other hand I don't want to fly completely blind in case
a bug has to be hunted.
> regards,
> Marc
Regards
Harald
next prev parent reply other threads:[~2022-11-03 13:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 13:44 [RFC PATCH 1/1] can: virtio: Initial virtio CAN driver Harald Mommer
2022-08-25 18:21 ` [virtio-dev] " Arnd Bergmann
2022-11-03 12:26 ` Harald Mommer
2022-11-04 10:50 ` Arnd Bergmann
2022-11-05 9:21 ` Vincent Mailhol
2023-05-12 13:19 ` Harald Mommer
2023-05-15 5:58 ` Vincent Mailhol
2023-05-23 13:39 ` Harald Mommer
2022-08-27 9:02 ` Oliver Hartkopp
2022-11-03 13:02 ` Harald Mommer
2022-08-27 9:39 ` Marc Kleine-Budde
2022-08-27 11:12 ` Oliver Hartkopp
2022-11-03 13:55 ` Harald Mommer [this message]
2022-11-04 15:32 ` [virtio-dev] " Jan Kiszka
2022-11-04 17:03 ` Arnd Bergmann
2023-02-03 15:02 ` Harald Mommer
2023-04-14 19:20 ` Marc Kleine-Budde
2023-04-18 9:50 ` Harald Mommer
2023-04-18 12:06 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40e3d678-b840-e780-c1da-367000724f69@opensynergy.com \
--to=hmo@opensynergy.com \
--cc=Dariusz.Stojaczyk@opensynergy.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=harald.mommer@opensynergy.com \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).