From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH net-next 0/7] net/ipv6: Fix route append and replace use
 cases
Date: Mon, 2 Jul 2018 15:23:19 -0600
Message-ID: <4140e322-39ad-3a1b-e6bf-9981f0310e02@gmail.com>
References: <20180521172658.7389-1-dsahern@kernel.org>
 <20180522.144617.1003575784676243779.davem@davemloft.net>
 <6d61c529-5b51-dc3b-86ee-e912f1a8e0a8@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, Thomas.Winter@alliedtelesis.co.nz,
        idosch@mellanox.com, sharpd@cumulusnetworks.com,
        roopa@cumulusnetworks.com
To: David Miller <davem@davemloft.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg0-f65.google.com ([74.125.83.65]:42415 "EHLO
        mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752808AbeGBVXW (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 2 Jul 2018 17:23:22 -0400
Received: by mail-pg0-f65.google.com with SMTP id c10-v6so7674608pgu.9
        for <netdev@vger.kernel.org>; Mon, 02 Jul 2018 14:23:22 -0700 (PDT)
In-Reply-To: <6d61c529-5b51-dc3b-86ee-e912f1a8e0a8@gmail.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 5/22/18 2:44 PM, David Ahern wrote:
> On 5/22/18 12:46 PM, David Miller wrote:
>>
>> Ok, I'll apply this series.
>>
>> But if this breaks things for anyone in a practical way, I am unfortunately
>> going to have to revert no matter how silly the current behavior may be.
>>
> 
> Understood. I have to try the best option first. I'll look at
> regressions if they happen.
> 

Debugging the problem Sowmini reported and I discovered NetworkManager
likes to manage link-local prefix routes (fe80::/64), and it likes to do
so with NLM_F_APPEND so the routes end up like this:

fe80::/64 dev eth0 proto kernel metric 100 pref medium
fe80::/64 dev eth1 proto kernel metric 101 pref medium
fe80::/64 proto kernel metric 256
        nexthop dev eth1 weight 1
        nexthop dev eth0 weight 1 pref medium

NM deletes the kernel installed routes, and then adds new ones -- twice:
once with the custom metric and then re-installs the route it deleted
but with the append flag.

Given the short amount of time left for 4.18 (and summer PTO), I think a
revert is the only option; we can try again in a future release.