netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: Matthias May <matthias.may@westermo.com>,
	Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
	yoshfuji@linux-ipv6.org, dsahern@kernel.org, edumazet@google.com,
	pabeni@redhat.com
Subject: Re: [PATCH net] ip_tunnel: allow to inherit from VLAN encapsulated IP frames
Date: Tue, 12 Jul 2022 09:17:48 +0200	[thread overview]
Message-ID: <42015af3-daa5-7435-725e-8197adbbf3b8@6wind.com> (raw)
In-Reply-To: <331695e3-bfa3-9ea7-3ba9-aebd0689251c@westermo.com>

Le 12/07/2022 à 00:06, Matthias May a écrit :
[snip]
> One thing that puzzles me a bit: Is there any reason why the IPv6 version of ip
> tunnels is so... distributed?
Someone does the factorization for ipv4, but nobody for ipv6 ;-)

> The IPv4 version does everything in a single function in ip_tunnels, while the
> IPv6 delegates some? of the parsing to
> the respective tunnel types, but then does some of the parsing again in
> ip6_tunnel (e.g the ttl parsing).
Note that geneve and vxlan use ip_tunnel_get_dsfield() / ip_tunnel_get_ttl()
which also miss the vlan case.

Regards,
Nicolas

  reply	other threads:[~2022-07-12  7:17 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-05 14:54 [PATCH net] ip_tunnel: allow to inherit from VLAN encapsulated IP frames Matthias May
2022-07-06  1:25 ` Jakub Kicinski
2022-07-06  7:07   ` Matthias May
2022-07-06 20:17     ` Jakub Kicinski
2022-07-07 11:57       ` Matthias May
2022-07-07 23:53         ` Jakub Kicinski
2022-07-07 13:59       ` Matthias May
2022-07-08  0:01         ` Jakub Kicinski
2022-07-09 20:09           ` Matthias May
2022-07-11 18:29             ` Jakub Kicinski
2022-07-11 22:06               ` Matthias May
2022-07-12  7:17                 ` Nicolas Dichtel [this message]
2022-07-12  7:51                   ` Matthias May
2022-07-12  8:09                     ` Nicolas Dichtel
2022-07-20 15:24                       ` Matthias May
2022-07-20 16:50                         ` Jakub Kicinski
2022-07-21  8:25                           ` Matthias May
2022-07-21  8:05                         ` Nicolas Dichtel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42015af3-daa5-7435-725e-8197adbbf3b8@6wind.com \
    --to=nicolas.dichtel@6wind.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=matthias.may@westermo.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).