From: Daniel Borkmann <daniel@iogearbox.net>
To: Magnus Karlsson <magnus.karlsson@gmail.com>,
magnus.karlsson@intel.com, bjorn.topel@intel.com, ast@kernel.org,
netdev@vger.kernel.org, jonathan.lemon@gmail.com
Cc: bpf@vger.kernel.org, john.fastabend@gmail.com
Subject: Re: [PATCH bpf-next] xsk: introduce padding between ring pointers
Date: Fri, 9 Oct 2020 17:03:44 +0200 [thread overview]
Message-ID: <43b0605d-f0c9-b81c-4d16-344a7832e083@iogearbox.net> (raw)
In-Reply-To: <1602166338-21378-1-git-send-email-magnus.karlsson@gmail.com>
On 10/8/20 4:12 PM, Magnus Karlsson wrote:
> From: Magnus Karlsson <magnus.karlsson@intel.com>
>
> Introduce one cache line worth of padding between the producer and
> consumer pointers in all the lockless rings. This so that the HW
> adjacency prefetcher will not prefetch the consumer pointer when the
> producer pointer is used and vice versa. This improves throughput
> performance for the l2fwd sample app with 2% on my machine with HW
> prefetching turned on.
>
> Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
Applied, thanks!
> net/xdp/xsk_queue.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/net/xdp/xsk_queue.h b/net/xdp/xsk_queue.h
> index dc1dd5e..3c235d2 100644
> --- a/net/xdp/xsk_queue.h
> +++ b/net/xdp/xsk_queue.h
> @@ -15,6 +15,10 @@
>
> struct xdp_ring {
> u32 producer ____cacheline_aligned_in_smp;
> + /* Hinder the adjacent cache prefetcher to prefetch the consumer pointer if the producer
> + * pointer is touched and vice versa.
> + */
> + u32 pad ____cacheline_aligned_in_smp;
> u32 consumer ____cacheline_aligned_in_smp;
> u32 flags;
> };
>
I was wondering whether we should even generalize this further for reuse
elsewhere e.g. ...
diff --git a/include/linux/cache.h b/include/linux/cache.h
index 1aa8009f6d06..5521dab01649 100644
--- a/include/linux/cache.h
+++ b/include/linux/cache.h
@@ -85,4 +85,17 @@
#define cache_line_size() L1_CACHE_BYTES
#endif
+/*
+ * Dummy element for use in structs in order to pad a cacheline
+ * aligned element with an extra cacheline to hinder the adjacent
+ * cache prefetcher to prefetch the subsequent struct element.
+ */
+#ifndef ____cacheline_padding_in_smp
+# ifdef CONFIG_SMP
+# define ____cacheline_padding_in_smp u8 :8 ____cacheline_aligned_in_smp
+# else
+# define ____cacheline_padding_in_smp
+# endif /* CONFIG_SMP */
+#endif
+
#endif /* __LINUX_CACHE_H */
diff --git a/net/xdp/xsk_queue.h b/net/xdp/xsk_queue.h
index cdb9cf3cd136..1da36423e779 100644
--- a/net/xdp/xsk_queue.h
+++ b/net/xdp/xsk_queue.h
@@ -15,11 +15,9 @@
struct xdp_ring {
u32 producer ____cacheline_aligned_in_smp;
- /* Hinder the adjacent cache prefetcher to prefetch the consumer
- * pointer if the producer pointer is touched and vice versa.
- */
- u32 pad ____cacheline_aligned_in_smp;
+ ____cacheline_padding_in_smp;
u32 consumer ____cacheline_aligned_in_smp;
+ ____cacheline_padding_in_smp;
u32 flags;
};
... was there any improvement to also pad after the consumer given the struct
xdp_ring is also embedded into other structs?
Thanks,
Daniel
next prev parent reply other threads:[~2020-10-09 15:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 14:12 [PATCH bpf-next] xsk: introduce padding between ring pointers Magnus Karlsson
2020-10-09 15:03 ` Daniel Borkmann [this message]
2020-10-12 8:37 ` Magnus Karlsson
2020-10-12 9:37 ` Magnus Karlsson
2020-10-12 11:13 ` Magnus Karlsson
2020-10-12 22:28 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43b0605d-f0c9-b81c-4d16-344a7832e083@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@kernel.org \
--cc=bjorn.topel@intel.com \
--cc=bpf@vger.kernel.org \
--cc=john.fastabend@gmail.com \
--cc=jonathan.lemon@gmail.com \
--cc=magnus.karlsson@gmail.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).