netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@lists.01.org, ast@kernel.org, jakub@cloudflare.com,
	andrii.nakryiko@gmail.com, netdev@vger.kernel.org,
	bpf@vger.kernel.org, Andrii Nakryiko <andriin@fb.com>,
	philip.li@intel.com, fengguang.wu@intel.com
Subject: Re: [PATCH bpf-next] bpf: add bpf_jit_blinding_enabled for !CONFIG_BPF_JIT
Date: Mon, 25 Nov 2019 08:27:19 +0100	[thread overview]
Message-ID: <4447a335-6311-3470-7546-dff06672a200@iogearbox.net> (raw)
In-Reply-To: <201911250641.xKeDIKoX%lkp@intel.com>

[ +Philip, +Fengguang ]

On 11/24/19 11:54 PM, kbuild test robot wrote:
> Hi Daniel,
> 
> I love your patch! Yet something to improve:
> 
> [auto build test ERROR on bpf-next/master]
> [cannot apply to v5.4-rc8 next-20191122]
> [if your patch is applied to the wrong git tree, please drop us a note to help
> improve the system. BTW, we also suggest to use '--base' option to specify the
> base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
> 
> url:    https://github.com/0day-ci/linux/commits/Daniel-Borkmann/bpf-add-bpf_jit_blinding_enabled-for-CONFIG_BPF_JIT/20191125-042008
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
> config: i386-tinyconfig (attached as .config)
> compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
> reproduce:
>          # save the attached .config to linux build tree
>          make ARCH=i386
> 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>     In file included from include/net/sock.h:59:0,
>                      from include/linux/tcp.h:19,
>                      from include/linux/ipv6.h:87,
>                      from include/net/ipv6.h:12,
>                      from include/linux/sunrpc/clnt.h:28,
>                      from include/linux/nfs_fs.h:32,
>                      from init/do_mounts.c:23:
>>> include/linux/filter.h:1061:20: error: redefinition of 'bpf_jit_blinding_enabled'
>      static inline bool bpf_jit_blinding_enabled(struct bpf_prog *prog)
>                         ^~~~~~~~~~~~~~~~~~~~~~~~
>     include/linux/filter.h:1056:20: note: previous definition of 'bpf_jit_blinding_enabled' was here
>      static inline bool bpf_jit_blinding_enabled(struct bpf_prog *prog)
>                         ^~~~~~~~~~~~~~~~~~~~~~~~

Hmm, can't reproduce with above .config for `make ARCH=i386`. The .config doesn't have
CONFIG_BPF_JIT, and given there's only exactly *one* definition of bpf_jit_blinding_enabled()
for CONFIG_BPF_JIT and *one* for !CONFIG_BPF_JIT this build bot warning feels invalid to me
(unless I'm completely blind and missing something obvious, but the succeeded kernel build
seems to agree with me).

Thanks,
Daniel

> vim +/bpf_jit_blinding_enabled +1061 include/linux/filter.h
> 
>    1060	
>> 1061	static inline bool bpf_jit_blinding_enabled(struct bpf_prog *prog)
>    1062	{
>    1063		return false;
>    1064	}
>    1065	
> 
> ---
> 0-DAY kernel test infrastructure                 Open Source Technology Center
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
> 


  reply	other threads:[~2019-11-25  7:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-23 20:37 Daniel Borkmann
2019-11-23 21:04 ` Alexei Starovoitov
2019-11-24 22:54 ` kbuild test robot
2019-11-25  7:27   ` Daniel Borkmann [this message]
2019-11-26  5:55     ` [kbuild-all] " Rong Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4447a335-6311-3470-7546-dff06672a200@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=andrii.nakryiko@gmail.com \
    --cc=andriin@fb.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=fengguang.wu@intel.com \
    --cc=jakub@cloudflare.com \
    --cc=kbuild-all@lists.01.org \
    --cc=lkp@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=philip.li@intel.com \
    --subject='Re: [PATCH bpf-next] bpf: add bpf_jit_blinding_enabled for '\!'CONFIG_BPF_JIT' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).