From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH 2/3] include: Convert ethernet mac address declarations to use ETH_ALEN Date: Mon, 29 Jul 2013 22:06:58 +0200 Message-ID: <4497056.HfyZknBA2p@vostro.rjw.lan> References: <2929374.frUlkyTFNL@vostro.rjw.lan> <1375126464.2075.46.camel@joe-AO722> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7Bit Cc: netdev@vger.kernel.org, Len Brown , Pantelis Antoniou , Vitaly Bordug , Steve Glendinning , Mauro Carvalho Chehab , Samuel Ortiz , "David S. Miller" , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-usb@vger.kernel.org, linux-media@vger.kernel.org To: Joe Perches Return-path: In-Reply-To: <1375126464.2075.46.camel@joe-AO722> Sender: linux-acpi-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Monday, July 29, 2013 12:34:24 PM Joe Perches wrote: > On Mon, 2013-07-29 at 13:59 +0200, Rafael J. Wysocki wrote: > > On Sunday, July 28, 2013 10:29:04 PM Joe Perches wrote: > > > It's convenient to have ethernet mac addresses use > > > ETH_ALEN to be able to grep for them a bit easier and > > > also to ensure that the addresses are __aligned(2). > [] > > > diff --git a/include/acpi/actbl2.h b/include/acpi/actbl2.h > [] > > > @@ -44,6 +44,8 @@ > [] > > > +#include > > > + > [] > > > @@ -605,7 +607,7 @@ struct acpi_ibft_nic { > [] > > > - u8 mac_address[6]; > > > + u8 mac_address[ETH_ALEN]; > > > Please don't touch this file. > > > > It comes from a code base outside of the kernel and should be kept in sync with > > the upstream. > > Which files in include/acpi have this characteristic? Generally, all whose names start with "ac" except for acpi_bus.h, acpi_drivers.h and acpi_numa.h. > Perhaps an include/acpi/README is appropriate. Yes, we can add one. Thanks, Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.