From: Tariq Toukan <tariqt@mellanox.com>
To: Fuqian Huang <huangfq.daxian@gmail.com>
Cc: Tariq Toukan <tariqt@mellanox.com>,
"David S. Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 87/87] ethernet: mlx4: remove memset after dma_alloc_coherent
Date: Sun, 30 Jun 2019 12:15:33 +0000 [thread overview]
Message-ID: <4645429b-1429-34bb-e181-74c461ace04a@mellanox.com> (raw)
In-Reply-To: <20190627174227.4726-1-huangfq.daxian@gmail.com>
On 6/27/2019 8:42 PM, Fuqian Huang wrote:
> In commit af7ddd8a627c
> ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"),
> dma_alloc_coherent has already zeroed the memory.
> So memset is not needed.
>
> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
> ---
> drivers/net/ethernet/mellanox/mlx4/eq.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx4/eq.c b/drivers/net/ethernet/mellanox/mlx4/eq.c
> index a5be27772b8e..c790a5fcea73 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/eq.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/eq.c
> @@ -1013,8 +1013,6 @@ static int mlx4_create_eq(struct mlx4_dev *dev, int nent,
>
> dma_list[i] = t;
> eq->page_list[i].map = t;
> -
> - memset(eq->page_list[i].buf, 0, PAGE_SIZE);
> }
>
> eq->eqn = mlx4_bitmap_alloc(&priv->eq_table.bitmap);
>
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
Thanks.
prev parent reply other threads:[~2019-06-30 12:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 17:42 [PATCH 87/87] ethernet: mlx4: remove memset after dma_alloc_coherent Fuqian Huang
2019-06-30 12:15 ` Tariq Toukan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4645429b-1429-34bb-e181-74c461ace04a@mellanox.com \
--to=tariqt@mellanox.com \
--cc=davem@davemloft.net \
--cc=huangfq.daxian@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).