netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Saeed Mahameed <saeedm@mellanox.com>
To: "wenxu@ucloud.cn" <wenxu@ucloud.cn>,
	Roi Dayan <roid@mellanox.com>, Or Gerlitz <ogerlitz@mellanox.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH v2] net/mlx5e: Add bonding device for indr block to offload the packet received from bonding device
Date: Fri, 17 May 2019 20:34:13 +0000	[thread overview]
Message-ID: <4702c2da4a5a8a065f36c5414fa4057ba9f12883.camel@mellanox.com> (raw)
In-Reply-To: <1558084668-21203-1-git-send-email-wenxu@ucloud.cn>

On Fri, 2019-05-17 at 17:17 +0800, wenxu@ucloud.cn wrote:
> From: wenxu <wenxu@ucloud.cn>
> 
> The mlx5e support the lag mode. When add mlx_p0 and mlx_p1 to bond0.
> packet received from mlx_p0 or mlx_p1 and in the ingress tc flower
> forward to vf0. The tc rule can't be offloaded because there is
> no indr_register_block for the bonding device.
> 
> Signed-off-by: wenxu <wenxu@ucloud.cn>

Hi Wenxu, thanks for the patch

I would like to wait for some feedback from Roi and his team, 
Guys can you please provide feedback ?

Thanks,
Saeed

> ---
>  drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
> b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
> index 91e24f1..134fa0b 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
> @@ -796,6 +796,7 @@ static int mlx5e_nic_rep_netdevice_event(struct
> notifier_block *nb,
>  	struct net_device *netdev = netdev_notifier_info_to_dev(ptr);
>  
>  	if (!mlx5e_tc_tun_device_to_offload(priv, netdev) &&
> +	    !netif_is_bond_master(netdev) &&
>  	    !is_vlan_dev(netdev))
>  		return NOTIFY_OK;
>  

  reply	other threads:[~2019-05-17 20:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-17  9:17 [PATCH v2] net/mlx5e: Add bonding device for indr block to offload the packet received from bonding device wenxu
2019-05-17 20:34 ` Saeed Mahameed [this message]
2019-05-17 22:11 ` Mark Bloch
2019-05-18  3:17   ` wenxu
2019-05-18  5:09     ` Mark Bloch
2019-05-19  7:23 ` Or Gerlitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4702c2da4a5a8a065f36c5414fa4057ba9f12883.camel@mellanox.com \
    --to=saeedm@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=ogerlitz@mellanox.com \
    --cc=roid@mellanox.com \
    --cc=wenxu@ucloud.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).