From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59422C433DF for ; Thu, 30 Jul 2020 17:22:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 43DB820809 for ; Thu, 30 Jul 2020 17:22:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729898AbgG3RWs (ORCPT ); Thu, 30 Jul 2020 13:22:48 -0400 Received: from smtprelay0185.hostedemail.com ([216.40.44.185]:33894 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726353AbgG3RWs (ORCPT ); Thu, 30 Jul 2020 13:22:48 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay07.hostedemail.com (Postfix) with ESMTP id B23D8181D3028; Thu, 30 Jul 2020 17:22:46 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: stick28_060683326f7c X-Filterd-Recvd-Size: 3622 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf02.hostedemail.com (Postfix) with ESMTPA; Thu, 30 Jul 2020 17:22:45 +0000 (UTC) Message-ID: <481224416317f5d690e7e28cd32b77bf06cdcec9.camel@perches.com> Subject: Re: [PATCH v1] qede: Use %pM format specifier for MAC addresses From: Joe Perches To: Alexander Lobakin , Andy Shevchenko Cc: Ariel Elior , GR-everest-linux-l2@marvell.com, netdev@vger.kernel.org, "David S. Miller" , Jakub Kicinski , linux-kernel@vger.kernel.org Date: Thu, 30 Jul 2020 10:22:43 -0700 In-Reply-To: References: Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.3-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 2020-07-30 at 16:29 +0000, Alexander Lobakin wrote: > From: Andy Shevchenko > Date: Thu, 30 Jul 2020 19:00:57 +0300 > > > Convert to %pM instead of using custom code. > > > > Signed-off-by: Andy Shevchenko > > --- > > drivers/net/ethernet/qlogic/qede/qede_main.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > Thanks! > > Acked-by: Alexander Lobakin > > > diff --git a/drivers/net/ethernet/qlogic/qede/qede_main.c b/drivers/net/ethernet/qlogic/qede/qede_main.c > > index 1aaae3203f5a..4250c17940c0 100644 > > --- a/drivers/net/ethernet/qlogic/qede/qede_main.c > > +++ b/drivers/net/ethernet/qlogic/qede/qede_main.c > > @@ -144,9 +144,7 @@ static int qede_set_vf_mac(struct net_device *ndev, int vfidx, u8 *mac) > > { > > struct qede_dev *edev = netdev_priv(ndev); > > > > - DP_VERBOSE(edev, QED_MSG_IOV, > > - "Setting MAC %02x:%02x:%02x:%02x:%02x:%02x to VF [%d]\n", > > - mac[0], mac[1], mac[2], mac[3], mac[4], mac[5], vfidx); > > + DP_VERBOSE(edev, QED_MSG_IOV, "Setting MAC %pM to VF [%d]\n", mac, vfidx); > > > > if (!is_valid_ether_addr(mac)) { > > DP_VERBOSE(edev, QED_MSG_IOV, "MAC address isn't valid\n"); > > -- > > 2.27.0 I would have expected the debugging output to be in the opposite order with the valid address test first. Something like: --- drivers/net/ethernet/qlogic/qede/qede_main.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qede/qede_main.c b/drivers/net/ethernet/qlogic/qede/qede_main.c index 1aaae3203f5a..30bf9aebd5b8 100644 --- a/drivers/net/ethernet/qlogic/qede/qede_main.c +++ b/drivers/net/ethernet/qlogic/qede/qede_main.c @@ -144,15 +144,15 @@ static int qede_set_vf_mac(struct net_device *ndev, int vfidx, u8 *mac) { struct qede_dev *edev = netdev_priv(ndev); - DP_VERBOSE(edev, QED_MSG_IOV, - "Setting MAC %02x:%02x:%02x:%02x:%02x:%02x to VF [%d]\n", - mac[0], mac[1], mac[2], mac[3], mac[4], mac[5], vfidx); - if (!is_valid_ether_addr(mac)) { - DP_VERBOSE(edev, QED_MSG_IOV, "MAC address isn't valid\n"); + DP_VERBOSE(edev, QED_MSG_IOV, + "Invalid MAC address %pM for VF [%d]\n", mac, vfidx); return -EINVAL; } + DP_VERBOSE(edev, QED_MSG_IOV, "Setting MAC %pM to VF [%d]\n", + mac, vfidx); + return edev->ops->iov->set_mac(edev->cdev, mac, vfidx); }