From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,
	URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 5654CC433E0
	for <netdev@archiver.kernel.org>; Mon, 22 Feb 2021 10:38:01 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 079A564E32
	for <netdev@archiver.kernel.org>; Mon, 22 Feb 2021 10:38:00 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230360AbhBVKho (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Mon, 22 Feb 2021 05:37:44 -0500
Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:14627 "EHLO
        hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S230297AbhBVKhj (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 22 Feb 2021 05:37:39 -0500
Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, AES256-SHA)
        id <B6033894a0000>; Mon, 22 Feb 2021 02:36:58 -0800
Received: from [172.27.13.143] (172.20.145.6) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 22 Feb
 2021 10:36:57 +0000
Subject: Re: [PATCH iproute2 v4 1/1] build: Fix link errors on some systems
To:     Petr Machata <petrm@nvidia.com>
CC:     <netdev@vger.kernel.org>, David Ahern <dsahern@gmail.com>,
        "Stephen Hemminger" <stephen@networkplumber.org>
References: <20210112103317.978952-1-roid@nvidia.com>
 <87h7nm73db.fsf@nvidia.com>
From:   Roi Dayan <roid@nvidia.com>
Message-ID: <482304af-beef-3703-2309-71e6611acec6@nvidia.com>
Date:   Mon, 22 Feb 2021 12:36:55 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <87h7nm73db.fsf@nvidia.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [172.20.145.6]
X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To
 HQMAIL107.nvidia.com (172.20.187.13)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1613990218; bh=/Z+noVKgIFT+ay4BBdKH849UGwVV/xCEW1VQW89FQqM=;
        h=Subject:To:CC:References:From:Message-ID:Date:User-Agent:
         MIME-Version:In-Reply-To:Content-Type:Content-Language:
         Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy;
        b=gQQBaXuXhRY5n77bCkVe8MTrhuZlBVU3WTb2UGkIRmbVZ2KasH6rAK5rd5jaD731Y
         VGwWiBDIR82Oid4rFXAsnikzMtS21xGmOVyZP2P1hGszPO5kjinqN9wPRxXb32sZSi
         bBL6+3GQmfSENX9p9NKaFERKLa3hbbkXt8VLEPykJ3qu5dbG2KU2onA0pDxShsMu1B
         +Za2J6UZs60kAfFxsTIEDaEhpJlz+fA6e4Dc/Hk3lqKEALeC72pnzrXVU5pK80kte1
         K9snNLB1uyGMHFNyyZZ2dHlDczuQgpqGNFdBjpHRLAY2UBBeAg9RSBfutJyfEw0LpF
         sgTMEkgkW7Szg==
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org



On 2021-01-12 2:21 PM, Petr Machata wrote:
> 
> Roi Dayan <roid@nvidia.com> writes:
> 
>> Since moving get_rate() and get_size() from tc to lib, on some
>> systems we fail to link because of missing math lib.
>> Move the functions that require math lib to their own c file
>> and add -lm to dcb that now use those functions.
>>
>> ../lib/libutil.a(utils.o): In function `get_rate':
>> utils.c:(.text+0x10dc): undefined reference to `floor'
>> ../lib/libutil.a(utils.o): In function `get_size':
>> utils.c:(.text+0x1394): undefined reference to `floor'
>> ../lib/libutil.a(json_print.o): In function `sprint_size':
>> json_print.c:(.text+0x14c0): undefined reference to `rint'
>> json_print.c:(.text+0x14f4): undefined reference to `rint'
>> json_print.c:(.text+0x157c): undefined reference to `rint'
>>
>> Fixes: f3be0e6366ac ("lib: Move get_rate(), get_rate64() from tc here")
>> Fixes: 44396bdfcc0a ("lib: Move get_size() from tc here")
>> Fixes: adbe5de96662 ("lib: Move sprint_size() from tc here, add print_size()")
>>
>> Signed-off-by: Roi Dayan <roid@nvidia.com>
> 
> Looking good:
> 
>      $ ldd ip/ip | grep libm.so
>      $ ldd dcb/dcb | grep libm.so
>              libm.so.6 => /lib64/libm.so.6 (0x00007f204d0c2000)
> 
> Reviewed-by: Petr Machata <petrm@nvidia.com>
> Tested-by: Petr Machata <petrm@nvidia.com>
> 

Hi,

Pinging about this commit. I noticed it was not taken.
anything you want me to update? push again?

Thanks,
Roi