From: Edward Cree <ecree@solarflare.com>
To: kernel test robot <lkp@intel.com>
Cc: <kbuild-all@lists.01.org>, netdev <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [linux-next:master 13398/13940] drivers/net/ethernet/sfc/ef100_nic.c:610: undefined reference to `__umoddi3'
Date: Thu, 6 Aug 2020 19:17:43 +0100 [thread overview]
Message-ID: <487d9159-41f8-2757-2e93-01426a527fb5@solarflare.com> (raw)
In-Reply-To: <202008060723.1gNgVvUi%lkp@intel.com>
On 06/08/2020 00:48, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: d15fe4ec043588beee823781602ddb51d0bc84c8
> commit: adcfc3482ffff813fa2c34e5902005853f79c2aa [13398/13940] sfc_ef100: read Design Parameters at probe time
> config: microblaze-randconfig-r032-20200805 (attached as .config)
> compiler: microblaze-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout adcfc3482ffff813fa2c34e5902005853f79c2aa
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=microblaze
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> microblaze-linux-ld: drivers/net/ethernet/sfc/ef100_nic.o: in function `ef100_process_design_param':
>>> drivers/net/ethernet/sfc/ef100_nic.c:610: undefined reference to `__umoddi3'
> 605 /* Our TXQ and RXQ sizes are always power-of-two and thus divisible by
> 606 * EFX_MIN_DMAQ_SIZE, so we just need to check that
> 607 * EFX_MIN_DMAQ_SIZE is divisible by GRANULARITY.
> 608 * This is very unlikely to fail.
> 609 */
> > 610 if (EFX_MIN_DMAQ_SIZE % reader->value) {
So, this is (unsigned long) % (u64), whichI guess doesn't go quite
as smoothly 32-bit microcontrollers (though the thought of plugging
a 100-gig smartNIC into a microblaze boggles the mind a little ;).
And none of the math64.h functions seem to have the shape we want —
div_u64_rem() wants to write the remainder through a pointer, and
do_div() wants to modify the dividend (which is a constant in this
case). So whatever I do, it's gonna be ugly :(
Maybe I should add a
static inline u32 mod_u64(u64 dividend, u32 divisor)
{
return do_div(dividend, divisor);
}
to include/linux/math64.h? At least that way the ugly is centralised
in the header file.
next parent reply other threads:[~2020-08-06 18:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <202008060723.1gNgVvUi%lkp@intel.com>
2020-08-06 18:17 ` Edward Cree [this message]
2020-08-10 15:51 ` [linux-next:master 13398/13940] drivers/net/ethernet/sfc/ef100_nic.c:610: undefined reference to `__umoddi3' Guenter Roeck
2020-08-11 8:55 ` Edward Cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=487d9159-41f8-2757-2e93-01426a527fb5@solarflare.com \
--to=ecree@solarflare.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).