From: Martin Schiller <ms@dev.tdt.de>
To: Xie He <xie.he.0141@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Shannon Nelson <snelson@pensando.io>,
Martin Habets <mhabets@solarflare.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Linux X25 <linux-x25@vger.kernel.org>
Subject: Re: [PATCH] drivers/net/wan/x25_asy: Fix to make it work
Date: Tue, 14 Jul 2020 10:07:10 +0200 [thread overview]
Message-ID: <490146353e9225245d8165b6edade1a9@dev.tdt.de> (raw)
In-Reply-To: <CAJht_EOqgWh0dShG258C3uoYdQga+EUae34tvL9HhqpztAv1PQ@mail.gmail.com>
On 2020-07-08 21:04, Xie He wrote:
> From: David Miller <davem@davemloft.net>
> Date: Wed, Jul 8, 2020 at 10:13 AM -0700
>> Something's not right, because I find it hard to believe this has been
>> so fundamentally broken for such a long period of time.
>>
>> Maybe the drivers all handle things differently, and whilst your
>> change
>> might fix some drivers, it will break others.
>>
>> I'm not applying this until this situation is better understood.
>
> Yes, it was hard for me to believe, too.
>
> At first when I tried this driver, it was silently not able to
> establish
> LAPB connections, I found that it was because it was ignoring
> 2-byte frames. I changed it to make 2-byte frames pass. Then I
> encountered kernel panic. I don't know how to solve it, so I looked
> at the way "lapbether" does things and changed this driver according
> to the "lapbether" driver. And it worked.
>
> The "lapbether" driver and this driver both use the "lapb" module to
> implement the LAPB protocol, so they should implement LAPB-related
> code in the same way.
>
> This patch only changes this driver and does not affect other drivers.
>
> I don't know how I can better explain this situation. Please tell me
> anything I can do to help. Thanks!
It really seems very strange that this driver seems to contain such
fundamental errors. I have never used it.
But the explanations and fixes look plausible to me.
next prev parent reply other threads:[~2020-07-14 8:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 4:37 [PATCH] drivers/net/wan/x25_asy: Fix to make it work Xie He
2020-07-08 17:13 ` David Miller
2020-07-08 19:04 ` Xie He
2020-07-09 4:15 ` Xie He
2020-07-14 8:07 ` Martin Schiller [this message]
2020-07-14 9:55 ` Xie He
2020-07-13 21:21 ` Eric Dumazet
2020-07-13 22:19 ` Xie He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=490146353e9225245d8165b6edade1a9@dev.tdt.de \
--to=ms@dev.tdt.de \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-x25@vger.kernel.org \
--cc=mhabets@solarflare.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=snelson@pensando.io \
--cc=xie.he.0141@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).