From: linmiaohe <linmiaohe@huawei.com>
To: Florian Westphal <fw@strlen.de>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"pshelar@ovn.org" <pshelar@ovn.org>,
"martin.varghese@nokia.com" <martin.varghese@nokia.com>,
"dcaratti@redhat.com" <dcaratti@redhat.com>,
"edumazet@google.com" <edumazet@google.com>,
"steffen.klassert@secunet.com" <steffen.klassert@secunet.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"shmulik@metanetworks.com" <shmulik@metanetworks.com>,
"kyk.segfault@gmail.com" <kyk.segfault@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: eliminate meaningless memcpy to data in pskb_carve_inside_nonlinear()
Date: Tue, 11 Aug 2020 11:54:28 +0000 [thread overview]
Message-ID: <4916edcf633b4f3290d8fde26167805c@huawei.com> (raw)
Florian Westphal <fw@strlen.de> wrote:
>Miaohe Lin <linmiaohe@huawei.com> wrote:
>> The skb_shared_info part of the data is assigned in the following loop.
>
>Where?
>
It's at the below for (i = 0; i < nfrags; i++) loop. But I missed something as Eric Dumazet pointed out.
Sorry about it.
next reply other threads:[~2020-08-11 11:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 11:54 linmiaohe [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-08-11 12:10 [PATCH] net: eliminate meaningless memcpy to data in pskb_carve_inside_nonlinear() linmiaohe
2020-08-11 15:35 ` Eric Dumazet
2020-08-10 12:28 Miaohe Lin
2020-08-10 13:56 ` Florian Westphal
2020-08-10 15:06 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4916edcf633b4f3290d8fde26167805c@huawei.com \
--to=linmiaohe@huawei.com \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=kuba@kernel.org \
--cc=kyk.segfault@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.varghese@nokia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pshelar@ovn.org \
--cc=shmulik@metanetworks.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).