From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_SBL,URIBL_SBL_A autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35528C48BD6 for ; Wed, 26 Jun 2019 15:29:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 159C12133F for ; Wed, 26 Jun 2019 15:29:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728120AbfFZP3o (ORCPT ); Wed, 26 Jun 2019 11:29:44 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:19116 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725958AbfFZP3o (ORCPT ); Wed, 26 Jun 2019 11:29:44 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 4A8C8D118A354417CDE0; Wed, 26 Jun 2019 23:29:37 +0800 (CST) Received: from [127.0.0.1] (10.133.213.239) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.439.0; Wed, 26 Jun 2019 23:29:31 +0800 Subject: Re: [PATCH] bonding: Always enable vlan tx offload To: Jiri Pirko References: <20190624135007.GA17673@nanopsycho> <20190626080844.20796-1-yuehaibing@huawei.com> <20190626152505.GB2424@nanopsycho> CC: , , , , , , , , , , , From: Yuehaibing Message-ID: <498bf1cb-1fb8-05a8-482a-79f37bf812dc@huawei.com> Date: Wed, 26 Jun 2019 23:29:30 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20190626152505.GB2424@nanopsycho> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.133.213.239] X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2019/6/26 23:25, Jiri Pirko wrote: > Wed, Jun 26, 2019 at 10:08:44AM CEST, yuehaibing@huawei.com wrote: >> We build vlan on top of bonding interface, which vlan offload >> is off, bond mode is 802.3ad (LACP) and xmit_hash_policy is >> BOND_XMIT_POLICY_ENCAP34. >> >> Because vlan tx offload is off, vlan tci is cleared and skb push >> the vlan header in validate_xmit_vlan() while sending from vlan >> devices. Then in bond_xmit_hash, __skb_flow_dissect() fails to >> get information from protocol headers encapsulated within vlan, >> because 'nhoff' is points to IP header, so bond hashing is based >> on layer 2 info, which fails to distribute packets across slaves. >> >> This patch always enable bonding's vlan tx offload, pass the vlan >> packets to the slave devices with vlan tci, let them to handle >> vlan implementation. >> >> Fixes: 278339a42a1b ("bonding: propogate vlan_features to bonding master") >> Suggested-by: Jiri Pirko >> Signed-off-by: YueHaibing > > Acked-by: Jiri Pirko > > Could you please do the same for team? Thanks! Sure, will send it, thank you! > > . >