Netdev Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v2] wimax/i2400m: fix a memory leak bug
@ 2019-08-15 20:29 Wenwen Wang
  2019-08-18 21:11 ` David Miller
  0 siblings, 1 reply; 3+ messages in thread
From: Wenwen Wang @ 2019-08-15 20:29 UTC (permalink / raw)
  To: Wenwen Wang
  Cc: Inaky Perez-Gonzalez, linux-wimax, David S. Miller, netdev, linux-kernel

In i2400m_barker_db_init(), 'options_orig' is allocated through kstrdup()
to hold the original command line options. Then, the options are parsed.
However, if an error occurs during the parsing process, 'options_orig' is
not deallocated, leading to a memory leak bug. To fix this issue, free
'options_orig' before returning the error.

Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
---
 drivers/net/wimax/i2400m/fw.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wimax/i2400m/fw.c b/drivers/net/wimax/i2400m/fw.c
index e9fc168..489cba9 100644
--- a/drivers/net/wimax/i2400m/fw.c
+++ b/drivers/net/wimax/i2400m/fw.c
@@ -351,13 +351,15 @@ int i2400m_barker_db_init(const char *_options)
 			}
 			result = i2400m_barker_db_add(barker);
 			if (result < 0)
-				goto error_add;
+				goto error_parse_add;
 		}
 		kfree(options_orig);
 	}
 	return 0;
 
+error_parse_add:
 error_parse:
+	kfree(options_orig);
 error_add:
 	kfree(i2400m_barker_db);
 	return result;
-- 
2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] wimax/i2400m: fix a memory leak bug
  2019-08-15 20:29 [PATCH v2] wimax/i2400m: fix a memory leak bug Wenwen Wang
@ 2019-08-18 21:11 ` David Miller
  2019-08-18 22:22   ` Perez-Gonzalez, Inaky
  0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2019-08-18 21:11 UTC (permalink / raw)
  To: wenwen; +Cc: inaky.perez-gonzalez, linux-wimax, netdev, linux-kernel

From: Wenwen Wang <wenwen@cs.uga.edu>
Date: Thu, 15 Aug 2019 15:29:51 -0500

> In i2400m_barker_db_init(), 'options_orig' is allocated through kstrdup()
> to hold the original command line options. Then, the options are parsed.
> However, if an error occurs during the parsing process, 'options_orig' is
> not deallocated, leading to a memory leak bug. To fix this issue, free
> 'options_orig' before returning the error.
> 
> Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>

Applied, but... looking at the rest of this file I hope nobody is actually
running this code.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] wimax/i2400m: fix a memory leak bug
  2019-08-18 21:11 ` David Miller
@ 2019-08-18 22:22   ` Perez-Gonzalez, Inaky
  0 siblings, 0 replies; 3+ messages in thread
From: Perez-Gonzalez, Inaky @ 2019-08-18 22:22 UTC (permalink / raw)
  To: David Miller; +Cc: wenwen, linux-wimax, netdev, linux-kernel

This driver should be orphaned. 

While I can’t certainly say nobody is using it, the HW has not been sold for years and it hasn’t been brought to current LK standards. 

If your assesment is the code shall not be used, it’s then another argument towards disconnecting it. 

> On Aug 18, 2019, at 14:12, David Miller <davem@davemloft.net> wrote:
> 
> From: Wenwen Wang <wenwen@cs.uga.edu>
> Date: Thu, 15 Aug 2019 15:29:51 -0500
> 
>> In i2400m_barker_db_init(), 'options_orig' is allocated through kstrdup()
>> to hold the original command line options. Then, the options are parsed.
>> However, if an error occurs during the parsing process, 'options_orig' is
>> not deallocated, leading to a memory leak bug. To fix this issue, free
>> 'options_orig' before returning the error.
>> 
>> Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
> 
> Applied, but... looking at the rest of this file I hope nobody is actually
> running this code.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-15 20:29 [PATCH v2] wimax/i2400m: fix a memory leak bug Wenwen Wang
2019-08-18 21:11 ` David Miller
2019-08-18 22:22   ` Perez-Gonzalez, Inaky

Netdev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git
	git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \
		netdev@vger.kernel.org netdev@archiver.kernel.org
	public-inbox-index netdev


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netdev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox