Re: [PATCH 2/2] net: minor update to Documentation/networking/scaling.txt

[Rick Jones <rick.jones2@hp.com>]

On 08/11/2011 05:41 PM, Willem de Bruijn wrote:
> Incorporate last comments about hyperthreading, interrupt coalescing and
> the definition of cache domains into the network scaling document scaling.txt
>
> Signed-off-by: Willem de Bruijn<willemb@google.com>
>
> ---
>   Documentation/networking/scaling.txt |   23 +++++++++++++++--------
>   1 files changed, 15 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/networking/scaling.txt b/Documentation/networking/scaling.txt
> index 3da03c3..6197126 100644
> --- a/Documentation/networking/scaling.txt
> +++ b/Documentation/networking/scaling.txt
> @@ -52,7 +52,8 @@ module parameter for specifying the number of hardware queues to
>   configure. In the bnx2x driver, for instance, this parameter is called
>   num_queues. A typical RSS configuration would be to have one receive queue
>   for each CPU if the device supports enough queues, or otherwise at least
> -one for each cache domain at a particular cache level (L1, L2, etc.).
> +one for each memory domain, where a memory domain is a set of CPUs that
> +share a particular memory level (L1, L2, NUMA node, etc.).

I'd suggest simply "share a particular level in the memory hierarchy 
(Cache, NUMA node, etc)"  and that way you get away from people asking 
nitpicky questions about where cache hierarchy counting starts, and at 
what level caches might be shared :)

Apart from that, looks fine.

rick jones