From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tore Anderson Subject: Re: [PATCH] ipv6: Send ICMPv6 RSes only when RAs are accepted Date: Fri, 16 Sep 2011 23:43:01 +0200 Message-ID: <4E73C2E5.2050901@fud.no> References: <201108291209.p7TC9KkD002967@wrath.fud.no> <20110916.171503.42153974977438913.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: David Miller Return-path: Received: from greed.fud.no ([87.238.35.20]:38374 "EHLO greed.fud.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754422Ab1IPWCr (ORCPT ); Fri, 16 Sep 2011 18:02:47 -0400 In-Reply-To: <20110916.171503.42153974977438913.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: * David Miller > From: Tore Anderson > Date: Mon, 29 Aug 2011 14:08:33 +0200 > >> The change also makes "Hybrid Router" forwarding mode ("forwarding" >> sysctl set to 2) redundant, as the only thing that distinguished it from >> the standard Router mode (forwarding=1) was that RSes was being sent. It >> has therefore been removed. > > You're not removing "accept_ra==2", it's still there in the test: > >> - if ((ifp->idev->cnf.forwarding == 0 || >> - ifp->idev->cnf.forwarding == 2) && >> + if (((ifp->idev->cnf.accept_ra == 1 && !ifp->idev->cnf.forwarding) || >> + ifp->idev->cnf.accept_ra == 2) && > > And it does provide it's own unique behavior compared to > "accept_ra==1". Hi David, I'm not removing accept_ra==2, no, only forwarding==2. Or, more precisely, I'm only removing the *documentation* for forwarding==2; forwarding==2 will still work, but there's no difference from forwarding==1 any longer. -- Tore Anderson