From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [PATCH ] dynamic_debug: call __netdev_printk only for CONFIG_NET Date: Mon, 19 Sep 2011 09:49:38 -0700 Message-ID: <4E7772A2.8010000@xenotime.net> References: <5514795fe63ccfd4b3a80283ed04a526abe3c59d.1313085588.git.jbaron@redhat.com> <201109011657.02407.arnd@arndb.de> <20110901151817.GA14324@redhat.com> <20110918082736.GB19444@kroah.com> <20110919134814.GA2658@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Greg KH , Arnd Bergmann , gregkh@suse.de, joe@perches.com, jim.cromie@gmail.com, bvanassche@acm.org, linux-kernel@vger.kernel.org, davem@davemloft.net, aloisio.almeida@openbossa.org, netdev@vger.kernel.org, akpm@linux-foundation.org To: Jason Baron Return-path: In-Reply-To: <20110919134814.GA2658@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 09/19/2011 06:48 AM, Jason Baron wrote: > On Sun, Sep 18, 2011 at 01:27:36AM -0700, Greg KH wrote: >> On Thu, Sep 01, 2011 at 11:18:18AM -0400, Jason Baron wrote: >>> On Thu, Sep 01, 2011 at 04:57:02PM +0200, Arnd Bergmann wrote: >>>> __netdev_printk is only defined when CONFIG_NET is set. Since we only need >>>> __dynamic_netdev_dbg for network drivers, we can make it conditional on the >>>> same Kconfig symbol. >>>> >>> >>> Hi, >>> >>> Yes, I've posted a fix for this: >>> >>> https://lkml.org/lkml/2011/8/30/297 >>> >>> Hopefully, it will be pulled in soon. >> >> As that thread again spun off into confusion, can you please resend the >> end result? >> >> thanks, >> >> greg k-h > > Hi, > > Andrew Morton has pulled these into his -mm tree...so I think the series > should be all set. Good. The build fix is still needed in today's linux-next (20110919). -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***