From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Grandegger Subject: Re: [PATCH net-next v2 2/4] can: cc770: add legacy ISA bus driver for the CC770 and AN82527 Date: Tue, 29 Nov 2011 10:16:28 +0100 Message-ID: <4ED4A2EC.40103@grandegger.com> References: <1322214204-1121-1-git-send-email-wg@grandegger.com> <1322214204-1121-3-git-send-email-wg@grandegger.com> <4ED0FEC5.3070108@hartkopp.net> <4ED34CAD.7040000@essax.com> <4ED351A8.8000102@grandegger.com> <4ED37885.8080909@essax.com> <4ED3B198.2040308@hartkopp.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-can-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, socketcan-users-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org, info-PyqsHJVlJN8AvxtiuMwx3w@public.gmane.org To: Oliver Hartkopp Return-path: In-Reply-To: <4ED3B198.2040308-fJ+pQTUTwRTk1uMJSBkQmQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: socketcan-users-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org Errors-To: socketcan-users-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org List-Id: netdev.vger.kernel.org On 11/28/2011 05:06 PM, Oliver Hartkopp wrote: > >>> ... using a reasonable default for bcr of 0x40. But you may need to >>> provide better values for cir, bcr and cor. >>> >> >> OMG, sorry that I was bothering You but You are absolutely right and with Your >> statement You brought be back on track and You made my day. Thank You !!!!!! >> >> I just took the values for cpu and bus I was using in my lincan driver and funny >> enough now it's working absolutely perfect. >> >> Module: modprobe cc770_isa irq=0xa port=0x384 indirect=1 cir=0x61 bcr=0x4A >> >> Was just sending 50000 telegrams, perfect and no problem at all. >> >> Thanks a lot again!!!! >> > > > This looks like a Tested-by :-) Wolfgang, I just sent out v4. Any chance to give this patch a try? It would be best to use a recent kernel version but I could also adapt the patch to your kernel version, 2.6.39, I think!? As you are using a CC770 chip, I'm especially interested in the relevant kernel log (dmesg) and "ip -d -s link show". Thanks, Wolfgang.