From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DE1DC43334 for ; Tue, 19 Jul 2022 22:04:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240722AbiGSWE6 (ORCPT ); Tue, 19 Jul 2022 18:04:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235993AbiGSWE5 (ORCPT ); Tue, 19 Jul 2022 18:04:57 -0400 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C60F65FAFB; Tue, 19 Jul 2022 15:04:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658268296; x=1689804296; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=pvIxtNbWUdkbgcKb5Tspz0IgM/n/C0XFuT/gdjfEdHk=; b=d+9SoWBzvY4RspCH01rdb72G1r3CGCbPL9uQvNpH6FCxp6/lvul4S8JU dOyt6cNy8PmGlH+xpm8UQ9yPJOJctF50vMNCIO4ZlNWCDGMB/WPy4iz8O zaTXOmIP4jlQN7Ad8K9XpfoE5TduQ0TLP1bpbMU8e/oaeNSbAVYabHDE2 WYPuL1EfiNOhGHY2tCmXOjkclFoMSXUWrUckT7UeUrD+nPo1KFs88bX2A /OdjxZ/pao3S67KXaCQAxsFgx5AWiQ5ke3kw9drc/wiICv60bu1G+UgLp eRnzszEaKyD+32QKpWW3LLQKrtlXrsdHmnUFmgYMmjvbTe48R1xRX2JKj w==; X-IronPort-AV: E=McAfee;i="6400,9594,10413"; a="350603408" X-IronPort-AV: E=Sophos;i="5.92,285,1650956400"; d="scan'208";a="350603408" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2022 15:04:56 -0700 X-IronPort-AV: E=Sophos;i="5.92,285,1650956400"; d="scan'208";a="843817003" Received: from avandeve-mobl.amr.corp.intel.com (HELO [10.209.102.45]) ([10.209.102.45]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2022 15:04:53 -0700 Message-ID: <4a9d64b5-0fa4-8294-c78c-37394a156325@linux.intel.com> Date: Tue, 19 Jul 2022 15:04:52 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 09/13] notifier: Show function names on notifier routines if DEBUG_NOTIFIERS is set Content-Language: en-US To: "Guilherme G. Piccoli" , akpm@linux-foundation.org, bhe@redhat.com, pmladek@suse.com, kexec@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, x86@kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com, alejandro.j.jimenez@oracle.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bp@alien8.de, corbet@lwn.net, d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com, dyoung@redhat.com, feng.tang@intel.com, gregkh@linuxfoundation.org, mikelley@microsoft.com, hidehiro.kawai.ez@hitachi.com, jgross@suse.com, john.ogness@linutronix.de, keescook@chromium.org, luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, senozhatsky@chromium.org, stern@rowland.harvard.edu, tglx@linutronix.de, vgoyal@redhat.com, vkuznets@redhat.com, will@kernel.org, Cong Wang , Sebastian Andrzej Siewior , Valentin Schneider , Xiaoming Ni References: <20220719195325.402745-1-gpiccoli@igalia.com> <20220719195325.402745-10-gpiccoli@igalia.com> <8e201d99-78a8-d68c-6d33-676a1ba5a6ee@igalia.com> <8ef53978-f26e-89e3-8b04-6f0eb183f200@igalia.com> From: Arjan van de Ven In-Reply-To: <8ef53978-f26e-89e3-8b04-6f0eb183f200@igalia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 7/19/2022 2:00 PM, Guilherme G. Piccoli wrote: > On 19/07/2022 17:48, Arjan van de Ven wrote: >> [...] >> I would totally support an approach where instead of pr_info, there's a tracepoint >> for these events (and that shouldnt' need to be conditional on a config option) >> >> that's not what the patch does though. > > This is a good idea Arjan! We could use trace events or pr_debug() - > which one do you prefer? > I'd go for a trace point to be honest