From: Roman Yeryomin <roman@advem.lv>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Vivien Didelot" <vivien.didelot@savoirfairelinux.com>,
netdev@vger.kernel.org, "Antti Seppälä" <a.seppala@gmail.com>,
"Colin Leitner" <colin.leitner@googlemail.com>,
"Gabor Juhos" <juhosg@openwrt.org>
Subject: Re: [PATCH 4/4] RFC: net: dsa: realtek-smi: Add Realtek SMI driver
Date: Fri, 10 Nov 2017 14:05:32 +0200 [thread overview]
Message-ID: <4b267f0c0b18fc2f00abb3c375227b70@advem.lv> (raw)
In-Reply-To: <32e08039-3a32-7543-9a79-847649a5a1ee@gmail.com>
On 2017-11-09 20:08, Florian Fainelli wrote:
> On 11/09/2017 09:24 AM, Andrew Lunn wrote:
>>> The registers writing code is where? switchdev driver?
>>> All I care about is that all the switch specific code should be in
>>> one
>>> place.
>>
>> The switch specific code is in the switch specific driver.
>>
>> Take a look under drivers/net/dsa for the switches which are currently
>> supported by DSA.
>
> And Roman, if you are thinking about converting existing swconfig
> drivers from OpenWrt/LEDE into DSA, please do it! The conversion is
> reasonably simple even if the APIs do not exactly match. Quite a lot of
> swconfig driers in OpenWrt/LEDE are implemented as phy_device, and the
> conversion for that is to use a proper mdio_device (see
> drivers/net/dsa/b53/b53_mdio.c for an example).
Yes, I'm thinking about that from time to time :)
> For the record, I tried submitting swconfig back in 2013, but this was
> rejected under the premise that it did not follow the simple paradigm
> that switch ports must be network devices. Also, swconfig is too
> permissive in that it allows switch drivers to come up with their own
> netlink attributes, whereas the desire is to standardize as much as
> possible on features, even if there is just one implementation for
> that.
Yes, saw it back then...
> The downside of not using swconfig is that you need multiple tools,
> iproute2 namely in order to obtain the same type of configuration, but
> this is a small price to pay because DSA is upstream, and upstream
> usually wins, and it wins even more when people start contributing the
> things they see missing.
Fully agree here
Regards,
Roman
next prev parent reply other threads:[~2017-11-10 12:05 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-05 23:19 [PATCH 0/4] RFC: Realtek 83xx SMI driver core Linus Walleij
2017-11-05 23:19 ` [PATCH 1/4] RFC: net/dsa: Allow DSA PHYs to define link IRQs Linus Walleij
2017-11-05 23:19 ` [PATCH 2/4] RFC: net: phy: realtek: Support RTL8366RB variant Linus Walleij
2017-11-05 23:19 ` [PATCH 3/4] RFC: net: dsa: Add bindings for Realtek SMI DSAs Linus Walleij
2017-11-05 23:48 ` Andrew Lunn
[not found] ` <20171105234831.GA24822-g2DYL2Zd6BY@public.gmane.org>
2017-11-29 12:24 ` Linus Walleij
2017-11-29 15:56 ` Andrew Lunn
2017-11-29 21:28 ` Linus Walleij
[not found] ` <CACRpkdZVXgFMiHpyUqw7ONYDcq6Htn3rTMRaBJkzd6T3WtX36A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-11-29 21:48 ` Florian Fainelli
2017-11-29 21:56 ` Andrew Lunn
[not found] ` <20171129215659.GC1706-g2DYL2Zd6BY@public.gmane.org>
2017-11-29 23:19 ` Linus Walleij
2017-11-29 23:26 ` Florian Fainelli
[not found] ` <f9bfa1e1-7f05-1e2b-6663-09d4d3bf6a12-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-11-29 23:36 ` Andrew Lunn
2017-12-02 12:56 ` Linus Walleij
[not found] ` <CACRpkdYoMVNh8eaTnaDQ59bsh4bC88biLaYSXyhnc4W83PMWzA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-12-04 22:50 ` Andrew Lunn
2017-11-05 23:19 ` [PATCH 4/4] RFC: net: dsa: realtek-smi: Add Realtek SMI driver Linus Walleij
2017-11-05 23:59 ` Andrew Lunn
2017-11-06 8:25 ` Linus Walleij
2017-11-09 12:49 ` Roman Yeryomin
2017-11-09 13:24 ` Andrew Lunn
2017-11-09 15:11 ` Roman Yeryomin
2017-11-09 15:38 ` Andrew Lunn
2017-11-09 17:21 ` Roman Yeryomin
2017-11-09 17:24 ` Andrew Lunn
2017-11-09 18:08 ` Florian Fainelli
2017-11-10 8:16 ` Linus Walleij
2017-11-10 12:05 ` Roman Yeryomin [this message]
2017-11-10 12:02 ` Roman Yeryomin
2017-11-10 13:51 ` Andrew Lunn
2017-11-10 12:17 ` Egil Hjelmeland
2017-11-10 14:01 ` Andrew Lunn
2018-04-02 16:10 ` [PATCH 0/4] RFC: Realtek 83xx SMI driver core Carl-Daniel Hailfinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b267f0c0b18fc2f00abb3c375227b70@advem.lv \
--to=roman@advem.lv \
--cc=a.seppala@gmail.com \
--cc=andrew@lunn.ch \
--cc=colin.leitner@googlemail.com \
--cc=f.fainelli@gmail.com \
--cc=juhosg@openwrt.org \
--cc=linus.walleij@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).