From: Jeff Layton <jlayton@kernel.org>
To: Anna Schumaker <anna@kernel.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Chuck Lever <chuck.lever@oracle.com>,
Alexander Aring <alex.aring@gmail.com>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Steve French <sfrench@samba.org>,
Paulo Alcantara <pc@manguebit.com>,
Ronnie Sahlberg <ronniesahlberg@gmail.com>,
Shyam Prasad N <sprasad@microsoft.com>,
Tom Talpey <tom@talpey.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
David Howells <dhowells@redhat.com>,
Tyler Hicks <code@tyhicks.com>, Neil Brown <neilb@suse.de>,
Olga Kornievskaia <kolga@netapp.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Miklos Szeredi <miklos@szeredi.hu>,
Amir Goldstein <amir73il@gmail.com>,
Namjae Jeon <linkinjeon@kernel.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org,
samba-technical@lists.samba.org, netfs@lists.linux.dev,
ecryptfs@vger.kernel.org, linux-unionfs@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH RFC 21/24] nfs: add a GDD_GETATTR rpc operation
Date: Fri, 15 Mar 2024 17:29:37 -0400 [thread overview]
Message-ID: <4c5c4f4df54f860aee9ba0ef18af815599d8642d.camel@kernel.org> (raw)
In-Reply-To: <CAFX2Jfk_np=agEWY0aPkosssBkfx9S+ur-L1=91psn-hdgK+RA@mail.gmail.com>
On Fri, 2024-03-15 at 16:50 -0400, Anna Schumaker wrote:
> Hi Jeff,
>
> On Fri, Mar 15, 2024 at 12:54 PM Jeff Layton <jlayton@kernel.org> wrote:
> >
> > Add a new compound that does a GET_DIR_DELEGATION just before doing a
> > GETATTR on an inode. Add a delegation stateid and a nf_status code to
> > struct nfs4_getattr_res to store the result.
> >
> > Signed-off-by: Jeff Layton <jlayton@kernel.org>
> > ---
> > fs/nfs/nfs4xdr.c | 136 ++++++++++++++++++++++++++++++++++++++++++++++++
> > include/linux/nfs4.h | 1 +
> > include/linux/nfs_xdr.h | 2 +
> > 3 files changed, 139 insertions(+)
> >
> > diff --git a/fs/nfs/nfs4xdr.c b/fs/nfs/nfs4xdr.c
> > index 1416099dfcd1..c28025018bda 100644
> > --- a/fs/nfs/nfs4xdr.c
> > +++ b/fs/nfs/nfs4xdr.c
> > @@ -391,6 +391,22 @@ static int decode_layoutget(struct xdr_stream *xdr, struct rpc_rqst *req,
> > XDR_QUADLEN(NFS4_MAX_SESSIONID_LEN) + 5)
> > #define encode_reclaim_complete_maxsz (op_encode_hdr_maxsz + 4)
> > #define decode_reclaim_complete_maxsz (op_decode_hdr_maxsz + 4)
> > +#define encode_get_dir_delegation_maxsz (op_encode_hdr_maxsz + \
> > + 4 /* gdda_signal_deleg_avail */ + \
> > + 8 /* gdda_notification_types */ + \
> > + nfstime4_maxsz /* gdda_child_attr_delay */ + \
> > + nfstime4_maxsz /* gdda_dir_attr_delay */ + \
> > + nfs4_fattr_bitmap_maxsz /* gdda_child_attributes */ + \
> > + nfs4_fattr_bitmap_maxsz /* gdda_dir_attributes */)
> > +
> > +#define decode_get_dir_delegation_maxsz (op_encode_hdr_maxsz + \
> > + 4 /* gddrnf_status */ + \
> > + encode_verifier_maxsz /* gddr_cookieverf */ + \
> > + encode_stateid_maxsz /* gddr_stateid */ + \
> > + 8 /* gddr_notification */ + \
> > + nfs4_fattr_bitmap_maxsz /* gddr_child_attributes */ + \
> > + nfs4_fattr_bitmap_maxsz /* gddr_dir_attributes */)
> > +
> > #define encode_getdeviceinfo_maxsz (op_encode_hdr_maxsz + \
> > XDR_QUADLEN(NFS4_DEVICEID4_SIZE) + \
> > 1 /* layout type */ + \
> > @@ -636,6 +652,18 @@ static int decode_layoutget(struct xdr_stream *xdr, struct rpc_rqst *req,
> > decode_putfh_maxsz + \
> > decode_getattr_maxsz + \
> > decode_renew_maxsz)
> > +#define NFS4_enc_gdd_getattr_sz (compound_encode_hdr_maxsz + \
> > + encode_sequence_maxsz + \
> > + encode_putfh_maxsz + \
> > + encode_get_dir_delegation_maxsz + \
> > + encode_getattr_maxsz + \
> > + encode_renew_maxsz)
> > +#define NFS4_dec_gdd_getattr_sz (compound_decode_hdr_maxsz + \
> > + decode_sequence_maxsz + \
> > + decode_putfh_maxsz + \
> > + decode_get_dir_delegation_maxsz + \
> > + decode_getattr_maxsz + \
> > + decode_renew_maxsz)
> > #define NFS4_enc_lookup_sz (compound_encode_hdr_maxsz + \
> > encode_sequence_maxsz + \
> > encode_putfh_maxsz + \
> > @@ -1981,6 +2009,30 @@ static void encode_sequence(struct xdr_stream *xdr,
> > }
> >
> > #ifdef CONFIG_NFS_V4_1
> > +static void
> > +encode_get_dir_delegation(struct xdr_stream *xdr, struct compound_hdr *hdr)
> > +{
> > + __be32 *p;
> > + struct timespec64 ts = {};
> > + u32 zerobm[1] = {};
> > +
> > + encode_op_hdr(xdr, OP_GET_DIR_DELEGATION, decode_get_dir_delegation_maxsz, hdr);
> > +
> > + /* We can't handle CB_RECALLABLE_OBJ_AVAIL yet */
> > + xdr_stream_encode_bool(xdr, false);
> > +
> > + /* for now, we request no notification types */
> > + xdr_encode_bitmap4(xdr, zerobm, ARRAY_SIZE(zerobm));
> > +
> > + /* Request no attribute updates */
> > + p = reserve_space(xdr, 12 + 12);
> > + p = xdr_encode_nfstime4(p, &ts);
> > + xdr_encode_nfstime4(p, &ts);
> > +
> > + xdr_encode_bitmap4(xdr, zerobm, ARRAY_SIZE(zerobm));
> > + xdr_encode_bitmap4(xdr, zerobm, ARRAY_SIZE(zerobm));
> > +}
> > +
> > static void
> > encode_getdeviceinfo(struct xdr_stream *xdr,
> > const struct nfs4_getdeviceinfo_args *args,
> > @@ -2334,6 +2386,25 @@ static void nfs4_xdr_enc_getattr(struct rpc_rqst *req, struct xdr_stream *xdr,
> > encode_nops(&hdr);
> > }
> >
> > +/*
> > + * Encode GDD_GETATTR request
> > + */
> > +static void nfs4_xdr_enc_gdd_getattr(struct rpc_rqst *req, struct xdr_stream *xdr,
> > + const void *data)
> > +{
> > + const struct nfs4_getattr_arg *args = data;
> > + struct compound_hdr hdr = {
> > + .minorversion = nfs4_xdr_minorversion(&args->seq_args),
> > + };
> > +
> > + encode_compound_hdr(xdr, req, &hdr);
> > + encode_sequence(xdr, &args->seq_args, &hdr);
> > + encode_putfh(xdr, args->fh, &hdr);
> > + encode_get_dir_delegation(xdr, &hdr);
> > + encode_getfattr(xdr, args->bitmask, &hdr);
> > + encode_nops(&hdr);
> > +}
> > +
>
> This function should be under a "#ifdef CONFIG_NFS_V4_1" to avoid the
> following compiler error:
>
> fs/nfs/nfs4xdr.c:2403:2: error: call to undeclared function
> 'encode_get_dir_delegation'; ISO C99 and later do not support implicit
> function declarations [-Wimplicit-function-declaration]
> 2403 | encode_get_dir_delegation(xdr, &hdr);
> | ^
>
Thanks Anna! I'll fix up both problems before the next iteration.
>
> > /*
> > * Encode a CLOSE request
> > */
> > @@ -5919,6 +5990,43 @@ static int decode_layout_stateid(struct xdr_stream *xdr, nfs4_stateid *stateid)
> > return decode_stateid(xdr, stateid);
> > }
> >
> > +static int decode_get_dir_delegation(struct xdr_stream *xdr,
> > + struct nfs4_getattr_res *res)
> > +{
> > + nfs4_verifier cookieverf;
> > + int status;
> > + u32 bm[1];
> > +
> > + status = decode_op_hdr(xdr, OP_GET_DIR_DELEGATION);
> > + if (status)
> > + return status;
> > +
> > + if (xdr_stream_decode_u32(xdr, &res->nf_status))
> > + return -EIO;
> > +
> > + if (res->nf_status == GDD4_UNAVAIL)
> > + return xdr_inline_decode(xdr, 4) ? 0 : -EIO;
> > +
> > + status = decode_verifier(xdr, &cookieverf);
> > + if (status)
> > + return status;
> > +
> > + status = decode_delegation_stateid(xdr, &res->deleg);
> > + if (status)
> > + return status;
> > +
> > + status = decode_bitmap4(xdr, bm, ARRAY_SIZE(bm));
> > + if (status < 0)
> > + return status;
> > + status = decode_bitmap4(xdr, bm, ARRAY_SIZE(bm));
> > + if (status < 0)
> > + return status;
> > + status = decode_bitmap4(xdr, bm, ARRAY_SIZE(bm));
> > + if (status < 0)
> > + return status;
> > + return 0;
> > +}
> > +
> > static int decode_getdeviceinfo(struct xdr_stream *xdr,
> > struct nfs4_getdeviceinfo_res *res)
> > {
> > @@ -6455,6 +6563,33 @@ static int nfs4_xdr_dec_getattr(struct rpc_rqst *rqstp, struct xdr_stream *xdr,
> > return status;
> > }
> >
> > +/*
> > + * Decode GDD_GETATTR response
> > + */
> > +static int nfs4_xdr_dec_gdd_getattr(struct rpc_rqst *rqstp, struct xdr_stream *xdr,
> > + void *data)
> > +{
> > + struct nfs4_getattr_res *res = data;
> > + struct compound_hdr hdr;
> > + int status;
> > +
> > + status = decode_compound_hdr(xdr, &hdr);
> > + if (status)
> > + goto out;
> > + status = decode_sequence(xdr, &res->seq_res, rqstp);
> > + if (status)
> > + goto out;
> > + status = decode_putfh(xdr);
> > + if (status)
> > + goto out;
> > + status = decode_get_dir_delegation(xdr, res);
> > + if (status)
> > + goto out;
> > + status = decode_getfattr(xdr, res->fattr, res->server);
> > +out:
> > + return status;
> > +}
> > +
>
> This needs to be under the same #ifdef, too.
>
> Thanks,
> Anna
>
> > /*
> > * Encode an SETACL request
> > */
> > @@ -7704,6 +7839,7 @@ const struct rpc_procinfo nfs4_procedures[] = {
> > PROC41(BIND_CONN_TO_SESSION,
> > enc_bind_conn_to_session, dec_bind_conn_to_session),
> > PROC41(DESTROY_CLIENTID,enc_destroy_clientid, dec_destroy_clientid),
> > + PROC41(GDD_GETATTR, enc_gdd_getattr, dec_gdd_getattr),
> > PROC42(SEEK, enc_seek, dec_seek),
> > PROC42(ALLOCATE, enc_allocate, dec_allocate),
> > PROC42(DEALLOCATE, enc_deallocate, dec_deallocate),
> > diff --git a/include/linux/nfs4.h b/include/linux/nfs4.h
> > index 11ad088b411d..86cbfd50ecd1 100644
> > --- a/include/linux/nfs4.h
> > +++ b/include/linux/nfs4.h
> > @@ -681,6 +681,7 @@ enum {
> > NFSPROC4_CLNT_LISTXATTRS,
> > NFSPROC4_CLNT_REMOVEXATTR,
> > NFSPROC4_CLNT_READ_PLUS,
> > + NFSPROC4_CLNT_GDD_GETATTR,
> > };
> >
> > /* nfs41 types */
> > diff --git a/include/linux/nfs_xdr.h b/include/linux/nfs_xdr.h
> > index d09b9773b20c..85ee37ccc25e 100644
> > --- a/include/linux/nfs_xdr.h
> > +++ b/include/linux/nfs_xdr.h
> > @@ -1072,6 +1072,8 @@ struct nfs4_getattr_res {
> > struct nfs4_sequence_res seq_res;
> > const struct nfs_server * server;
> > struct nfs_fattr * fattr;
> > + nfs4_stateid deleg;
> > + u32 nf_status;
> > };
> >
> > struct nfs4_link_arg {
> >
> > --
> > 2.44.0
> >
--
Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2024-03-15 21:29 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 16:52 [PATCH RFC 00/24] vfs, nfsd, nfs: implement directory delegations Jeff Layton
2024-03-15 16:52 ` [PATCH RFC 01/24] filelock: push the S_ISREG check down to ->setlease handlers Jeff Layton
2024-03-15 16:52 ` [PATCH RFC 02/24] filelock: add a lm_set_conflict lease_manager callback Jeff Layton
2024-03-17 14:56 ` Chuck Lever
2024-03-18 11:07 ` Jeff Layton
2024-03-20 13:13 ` Christian Brauner
2024-03-20 13:17 ` Jeff Layton
2024-03-15 16:52 ` [PATCH RFC 03/24] vfs: add try_break_deleg calls for parents to vfs_{link,rename,unlink} Jeff Layton
2024-03-16 23:57 ` Al Viro
2024-03-17 14:09 ` Jeff Layton
2024-03-15 16:52 ` [PATCH RFC 04/24] vfs: allow mkdir to wait for delegation break on parent Jeff Layton
2024-03-15 16:52 ` [PATCH RFC 05/24] vfs: allow rmdir " Jeff Layton
2024-03-15 16:52 ` [PATCH RFC 06/24] vfs: break parent dir delegations in open(..., O_CREAT) codepath Jeff Layton
2024-03-17 0:19 ` Al Viro
2024-03-17 12:23 ` Jeff Layton
2024-03-18 8:25 ` Stefan Metzmacher
2024-03-18 10:21 ` Jeff Layton
2024-03-15 16:52 ` [PATCH RFC 07/24] vfs: make vfs_create break delegations on parent directory Jeff Layton
2024-03-15 16:52 ` [PATCH RFC 08/24] vfs: make vfs_mknod " Jeff Layton
2024-03-20 13:42 ` Christian Brauner
2024-03-20 20:12 ` Jeff Layton
2024-03-22 14:13 ` Christian Brauner
2024-03-15 16:53 ` [PATCH RFC 09/24] filelock: lift the ban on directory leases in generic_setlease Jeff Layton
2024-03-15 16:53 ` [PATCH RFC 10/24] nfsd: allow filecache to hold S_IFDIR files Jeff Layton
2024-03-15 16:53 ` [PATCH RFC 11/24] nfsd: allow DELEGRETURN on directories Jeff Layton
2024-03-17 15:09 ` Chuck Lever
2024-03-17 16:03 ` Trond Myklebust
2024-03-18 11:22 ` Jeff Layton
2024-03-15 16:53 ` [PATCH RFC 12/24] nfsd: encoders and decoders for GET_DIR_DELEGATION Jeff Layton
2024-03-17 15:34 ` Chuck Lever
2024-03-18 16:12 ` Jeff Layton
2024-03-18 16:19 ` Chuck Lever
2024-03-15 16:53 ` [PATCH RFC 13/24] nfsd: check for delegation conflicts vs. the same client Jeff Layton
2024-03-15 16:53 ` [PATCH RFC 14/24] nfsd: wire up GET_DIR_DELEGATION handling Jeff Layton
2024-03-17 15:42 ` Chuck Lever
2024-03-15 16:53 ` [PATCH RFC 15/24] nfs: fix nfs_stateid_hash prototype when CONFIG_CRC32 isn't set Jeff Layton
2024-03-15 16:53 ` [PATCH RFC 16/24] nfs: remove unused NFS_CALL macro Jeff Layton
2024-03-15 16:53 ` [PATCH RFC 17/24] nfs: add cache_validity to the nfs_inode_event tracepoints Jeff Layton
2024-03-15 16:53 ` [PATCH RFC 18/24] nfs: add a tracepoint to nfs_inode_detach_delegation_locked Jeff Layton
2024-03-15 16:53 ` [PATCH RFC 19/24] nfs: new tracepoint in nfs_delegation_need_return Jeff Layton
2024-03-15 16:53 ` [PATCH RFC 20/24] nfs: new tracepoint in match_stateid operation Jeff Layton
2024-03-15 16:53 ` [PATCH RFC 21/24] nfs: add a GDD_GETATTR rpc operation Jeff Layton
2024-03-15 20:50 ` Anna Schumaker
2024-03-15 21:29 ` Jeff Layton [this message]
2024-03-15 16:53 ` [PATCH RFC 22/24] nfs: skip dentry revalidation when parent dir has a delegation Jeff Layton
2024-03-15 16:53 ` [PATCH RFC 23/24] nfs: optionally request a delegation on GETATTR Jeff Layton
2024-03-15 16:53 ` [PATCH RFC 24/24] nfs: add a module parameter to disable directory delegations Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c5c4f4df54f860aee9ba0ef18af815599d8642d.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=Dai.Ngo@oracle.com \
--cc=alex.aring@gmail.com \
--cc=amir73il@gmail.com \
--cc=anna@kernel.org \
--cc=brauner@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=code@tyhicks.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=ecryptfs@vger.kernel.org \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jack@suse.cz \
--cc=kolga@netapp.com \
--cc=kuba@kernel.org \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
--cc=netfs@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=pc@manguebit.com \
--cc=rafael@kernel.org \
--cc=ronniesahlberg@gmail.com \
--cc=samba-technical@lists.samba.org \
--cc=senozhatsky@chromium.org \
--cc=sfrench@samba.org \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
--cc=trond.myklebust@hammerspace.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).