From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
Anders Roxell <anders.roxell@linaro.org>
Cc: marex@denx.de, stefan@agner.ch, airlied@linux.ie,
shawnguo@kernel.org, s.hauer@pengutronix.de, andrew@lunn.ch,
vivien.didelot@gmail.com, f.fainelli@gmail.com,
a.hajda@samsung.com, mchehab@kernel.org, p.zabel@pengutronix.de,
hkallweit1@gmail.com, lee.jones@linaro.org, lgirdwood@gmail.com,
broonie@kernel.org, davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-fbdev@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH 3/8] drivers: (video|gpu): fix warning same module names
Date: Fri, 7 Jun 2019 14:05:29 +0200 [thread overview]
Message-ID: <4c9681c0-5ead-3e4c-584b-c4e98cd94480@samsung.com> (raw)
In-Reply-To: <20190607075728.GE21222@phenom.ffwll.local>
On 6/7/19 9:57 AM, Daniel Vetter wrote:
> On Thu, Jun 06, 2019 at 11:47:12AM +0200, Anders Roxell wrote:
>> When building with CONFIG_DRM_MXSFB and CONFIG_FB_MXS enabled as
>> loadable modules, we see the following warning:
>>
>> warning: same module names found:
>> drivers/video/fbdev/mxsfb.ko
>> drivers/gpu/drm/mxsfb/mxsfb.ko
>>
>> Rework so the names matches the config fragment.
>>
>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> I'm assuming Bart will pick this one up for fbdev.
The DRM mxsfb has been a default for almost a year (since July
2018) and I've just applied "[PATCH] video: fbdev: mxsfb: Remove
driver" (https://marc.info/?l=dri-devel&m=155835758115686&w=2)
so it seems that this patch is not needed any longer (sorry!).
> -Daniel
>
>> ---
>> drivers/gpu/drm/mxsfb/Makefile | 4 ++--
>> drivers/video/fbdev/Makefile | 3 ++-
>> 2 files changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/mxsfb/Makefile b/drivers/gpu/drm/mxsfb/Makefile
>> index ff6e358088fa..5d49d7548e66 100644
>> --- a/drivers/gpu/drm/mxsfb/Makefile
>> +++ b/drivers/gpu/drm/mxsfb/Makefile
>> @@ -1,3 +1,3 @@
>> # SPDX-License-Identifier: GPL-2.0-only
>> -mxsfb-y := mxsfb_drv.o mxsfb_crtc.o mxsfb_out.o
>> -obj-$(CONFIG_DRM_MXSFB) += mxsfb.o
>> +drm-mxsfb-y := mxsfb_drv.o mxsfb_crtc.o mxsfb_out.o
>> +obj-$(CONFIG_DRM_MXSFB) += drm-mxsfb.o
>> diff --git a/drivers/video/fbdev/Makefile b/drivers/video/fbdev/Makefile
>> index 655f2537cac1..7ee967525af2 100644
>> --- a/drivers/video/fbdev/Makefile
>> +++ b/drivers/video/fbdev/Makefile
>> @@ -131,7 +131,8 @@ obj-$(CONFIG_FB_VGA16) += vga16fb.o
>> obj-$(CONFIG_FB_OF) += offb.o
>> obj-$(CONFIG_FB_MX3) += mx3fb.o
>> obj-$(CONFIG_FB_DA8XX) += da8xx-fb.o
>> -obj-$(CONFIG_FB_MXS) += mxsfb.o
>> +obj-$(CONFIG_FB_MXS) += fb-mxs.o
>> +fb-mxs-objs := mxsfb.o
>> obj-$(CONFIG_FB_SSD1307) += ssd1307fb.o
>> obj-$(CONFIG_FB_SIMPLE) += simplefb.o
>>
>> --
>> 2.20.1
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
prev parent reply other threads:[~2019-06-07 12:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 9:47 [PATCH 3/8] drivers: (video|gpu): fix warning same module names Anders Roxell
2019-06-07 7:57 ` Daniel Vetter
2019-06-07 12:05 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c9681c0-5ead-3e4c-584b-c4e98cd94480@samsung.com \
--to=b.zolnierkie@samsung.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=anders.roxell@linaro.org \
--cc=andrew@lunn.ch \
--cc=broonie@kernel.org \
--cc=daniel.vetter@ffwll.ch \
--cc=davem@davemloft.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=marex@denx.de \
--cc=mchehab@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).