From: Bitterblue Smith <rtl8821cerfe2@gmail.com>
To: Jun ASAKA <JunASAKA@zzy040330.moe>, Jes.Sorensen@gmail.com
Cc: kvalo@kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wifi: rtl8xxxu: fixing transmisison failure for rtl8192eu
Date: Sun, 8 Jan 2023 14:49:12 +0200 [thread overview]
Message-ID: <4ce57d51-0b53-6258-d003-ebb4a2eb4b82@gmail.com> (raw)
In-Reply-To: <56a335f1-3558-e496-4b0b-b024a935f881@zzy040330.moe>
On 08/01/2023 11:29, Jun ASAKA wrote:
> On 07/01/2023 22:17, Bitterblue Smith wrote:
>
>> On 17/12/2022 05:06, Jun ASAKA wrote:
>>> Fixing transmission failure which results in
>>> "authentication with ... timed out". This can be
>>> fixed by disable the REG_TXPAUSE.
>>>
>>> Signed-off-by: Jun ASAKA <JunASAKA@zzy040330.moe>
>>> ---
>>> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c
>>> index a7d76693c02d..9d0ed6760cb6 100644
>>> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c
>>> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c
>>> @@ -1744,6 +1744,11 @@ static void rtl8192e_enable_rf(struct rtl8xxxu_priv *priv)
>>> val8 = rtl8xxxu_read8(priv, REG_PAD_CTRL1);
>>> val8 &= ~BIT(0);
>>> rtl8xxxu_write8(priv, REG_PAD_CTRL1, val8);
>>> +
>>> + /*
>>> + * Fix transmission failure of rtl8192e.
>>> + */
>>> + rtl8xxxu_write8(priv, REG_TXPAUSE, 0x00);
>>> }
>>> static s8 rtl8192e_cck_rssi(struct rtl8xxxu_priv *priv, u8 cck_agc_rpt)
>> By the way, you should get this into the stable kernels too:
>> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
>
> I see.
>
> But since this patch has not been merged into Linus' tree yet, so should I wait until this patch is merged or I should issue a v2 patch here and Cc it to "table@vger.kernel.org"?
>
>
> Jun ASAKA.
>
Ah, yeah. Wait then.
next prev parent reply other threads:[~2023-01-08 12:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-17 3:06 [PATCH] wifi: rtl8xxxu: fixing transmisison failure for rtl8192eu Jun ASAKA
2022-12-20 5:44 ` Ping-Ke Shih
2022-12-20 6:02 ` Jun ASAKA
2022-12-20 13:03 ` Bitterblue Smith
2022-12-20 13:48 ` Jun ASAKA
2022-12-21 1:42 ` Ping-Ke Shih
2022-12-21 12:14 ` Bitterblue Smith
2022-12-21 18:52 ` Kalle Valo
2023-01-07 14:17 ` Bitterblue Smith
2023-01-08 9:29 ` Jun ASAKA
2023-01-08 12:49 ` Bitterblue Smith [this message]
2023-02-24 16:44 ` Bitterblue Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ce57d51-0b53-6258-d003-ebb4a2eb4b82@gmail.com \
--to=rtl8821cerfe2@gmail.com \
--cc=Jes.Sorensen@gmail.com \
--cc=JunASAKA@zzy040330.moe \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).