netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Yossi Kuperman <yossiku@mellanox.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Jamal Hadi Salim <jhs@mojatatu.com>,
	Jiri Pirko <jiri@mellanox.com>
Cc: Rony Efraim <ronye@mellanox.com>
Subject: Re: [RFC] Packet pacing (offload) for flow-aggregates and forwarding use-cases
Date: Tue, 24 Mar 2020 12:26:34 -0700	[thread overview]
Message-ID: <4d16c8e8-31d2-e3a4-2ff9-de0c9dc12d2e@gmail.com> (raw)
In-Reply-To: <d3d764d5-8eb6-59f9-cd3b-815de0258dbc@mellanox.com>



On 3/24/20 12:05 PM, Yossi Kuperman wrote:
> Hello,
> 
>  
> 
> We would like to support a forwarding use-case in which flows are classified and paced
> 
> according to the selected class. For example, a packet arrives at the ingress hook of interface
> 
> eth0,  performing a sequence of filters and being redirected to interface eth1. Pacing takes
> 
> place at the egress qdisc of eth1.
> 
>  
> 
> FQ queuing discipline is classless and cannot provide such functionality. Each flow is
> 
> paced independently, and different pacing is only configurable via a socket-option—less
> 
> suitable for forwarding  use-case.
> 
>  
> 
> It is worth noting that although this functionality might be implemented by stacking multiple
> 
> queuing disciplines, it will be very difficult to offload to hardware.
> 
>  
> 
> We propose introducing yet another classful qdisc, where the user can specify in advance the
> 
> desired classes (i.e. pacing) and provide filters to classify flows accordingly. Similar to other
> 
> qdiscs, if skb->priority is already set, we can skip the classification; useful for forwarding
> 
> use-case, as the user can set the priority field in ingress. Works nicely with OVS/TC.
> 
>  
> 
> Any thoughts please?
> 

Why not using HTB for this typical use case ?

       reply	other threads:[~2020-03-24 19:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <d3d764d5-8eb6-59f9-cd3b-815de0258dbc@mellanox.com>
2020-03-24 19:26 ` Eric Dumazet [this message]
2020-03-26 14:42   ` [RFC] Packet pacing (offload) for flow-aggregates and forwarding use-cases Yossi Kuperman
2020-04-06 20:26     ` Yossi Kuperman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d16c8e8-31d2-e3a4-2ff9-de0c9dc12d2e@gmail.com \
    --to=eric.dumazet@gmail.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=ronye@mellanox.com \
    --cc=yossiku@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).