From: David Ahern <dsahern@gmail.com>
To: Hangbin Liu <liuhangbin@gmail.com>, netdev@vger.kernel.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Phil Sutter <phil@nwl.cc>, Michal Kubecek <mkubecek@suse.cz>
Subject: Re: [PATCHv2 iproute2-next] ip/geneve: fix ttl inherit behavior
Date: Sun, 21 Oct 2018 09:55:52 -0600 [thread overview]
Message-ID: <4d9f9f90-7c36-67d8-980a-0bc947d46e7b@gmail.com> (raw)
In-Reply-To: <1539846110-11607-1-git-send-email-liuhangbin@gmail.com>
On 10/18/18 1:01 AM, Hangbin Liu wrote:
> Currently when we add geneve with "ttl inherit", we only set ttl to 0, which
> is actually use whatever default value instead of inherit the inner protocol's
> ttl value.
>
> To make a difference with ttl inherit and ttl == 0, we add an attribute
> IFLA_GENEVE_TTL_INHERIT in kernel commit 52d0d404d39dd ("geneve: add ttl
> inherit support"). Now let's use "ttl inherit" to inherit the inner
> protocol's ttl, and use "ttl auto" to means "use whatever default value",
> the same behavior with ttl == 0.
>
> v2:
> 1) remove IFLA_GENEVE_TTL_INHERIT defination in if_link.h as it's already
> updated.
> 2) Still use addattr8() so we can enable/disable ttl inherit, as Michal
> suggested.
>
> Reported-by: Jianlin Shi <jishi@redhat.com>
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
> ip/iplink_geneve.c | 20 +++++++++++++-------
> 1 file changed, 13 insertions(+), 7 deletions(-)
>
please update the man page as well.
next prev parent reply other threads:[~2018-10-22 0:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 7:27 [PATCH iproute2-next] geneve: fix ttl inherit behavior Hangbin Liu
2018-09-27 9:08 ` Phil Sutter
2018-09-28 0:59 ` Hangbin Liu
2018-10-18 7:01 ` [PATCHv2 iproute2-next] ip/geneve: " Hangbin Liu
2018-10-21 15:55 ` David Ahern [this message]
2018-10-22 7:46 ` [PATCHv3 " Hangbin Liu
2018-10-23 17:54 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d9f9f90-7c36-67d8-980a-0bc947d46e7b@gmail.com \
--to=dsahern@gmail.com \
--cc=liuhangbin@gmail.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).