From: Joe Perches <joe@perches.com>
To: Bjorn Helgaas <helgaas@kernel.org>,
Alan Cox <gnomes@lxorguk.ukuu.org.uk>
Cc: Puranjay Mohan <puranjay12@gmail.com>,
Shuah Khan <skhan@linuxfoundation.org>,
Bjorn Helgaas <bjorn@helgaas.com>,
netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v3 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates
Date: Fri, 21 Jun 2019 10:59:21 -0700 [thread overview]
Message-ID: <5025da034080c6653b23d7362e06cf211d2cec3c.camel@perches.com> (raw)
In-Reply-To: <20190621164429.GA187016@google.com>
On Fri, 2019-06-21 at 11:44 -0500, Bjorn Helgaas wrote:
> On Fri, Jun 21, 2019 at 04:20:24PM +0100, Alan Cox wrote:
> > On Fri, 21 Jun 2019 15:16:04 +0530
> > Puranjay Mohan <puranjay12@gmail.com> wrote:
> >
> > > This patch series removes the private duplicates of PCI definitions in
> > > favour of generic definitions defined in pci_regs.h.
> >
> > Why bother ? It's an ancient obsolete card ?
>
> That's a fair question.
>
> Is there anything that would indicate that "this file is obsolete and
> problems shouldn't be fixed"? Nobody wants to waste time on things
> that don't need to be fixed, but I don't know how to tell if something
> is obsolete.
>
> My naive assumption is that if something is in the tree, it's fair
> game for fixes and cleanups.
I'd prefer to move the old, crufty, obsolete and generally
unsupported drivers to new directory trees and possibly
symlink those drivers to their current locations.
I suggested on the kernel summit list:
https://lists.linuxfoundation.org/pipermail/ksummit-discuss/2019-June/006482.html
---
Perhaps a mechanism to move these old, generally unsupported
by an actual maintainer, and rarely tested drivers out of the
mainline drivers directory into a separate obsolete directory
would help isolate the whitespace and trivial api changes.
prev parent reply other threads:[~2019-06-21 17:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 9:46 [PATCH v3 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates Puranjay Mohan
2019-06-21 9:46 ` [PATCH v3 1/3] net: fddi: skfp: Rename local PCI defines to match generic PCI defines Puranjay Mohan
2019-06-21 9:46 ` [PATCH v3 2/3] net: fddi: skfp: Include generic PCI definitions Puranjay Mohan
2019-06-21 9:46 ` [PATCH v3 3/3] net: fddi: skfp: Remove unused private " Puranjay Mohan
2019-06-21 14:05 ` [PATCH v3 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates Bjorn Helgaas
2019-06-21 15:20 ` Alan Cox
2019-06-21 16:36 ` Shuah Khan
2019-06-26 20:03 ` David Miller
2019-06-21 16:44 ` Bjorn Helgaas
2019-06-21 17:59 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5025da034080c6653b23d7362e06cf211d2cec3c.camel@perches.com \
--to=joe@perches.com \
--cc=bjorn@helgaas.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=helgaas@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=puranjay12@gmail.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).