From: Gerlando Falauto <gerlando.falauto@keymile.com>
To: David Miller <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"sergei.shtylyov@cogentembedded.com"
<sergei.shtylyov@cogentembedded.com>,
"jon.maloy@ericsson.com" <jon.maloy@ericsson.com>,
"erik.hugne@ericsson.com" <erik.hugne@ericsson.com>,
"ying.xue@windriver.com" <ying.xue@windriver.com>,
"Brunck, Holger" <Holger.Brunck@keymile.com>
Subject: Re: [PATCH v3b 1/3] tipc: cosmetic: clean up comments and break a long line
Date: Wed, 01 May 2013 19:35:09 +0200 [thread overview]
Message-ID: <5181524D.6000207@keymile.com> (raw)
In-Reply-To: <20130501.131602.899596493606702378.davem@davemloft.net>
Hi,
On 05/01/2013 07:16 PM, David Miller wrote:
> From: Gerlando Falauto <gerlando.falauto@keymile.com>
> Date: Wed, 1 May 2013 18:41:17 +0200
>
>> Signed-off-by: Gerlando Falauto <gerlando.falauto@keymile.com>
>> ---
>> Changes from v3:
>> * Added "and break a long line" to the commit message
>> Changes from v2:
>> * Split cosmetic (this patch) from functional changes (next patch)
>
> Never resubmit patches by themselves, always resubmit the entire series.
I was just wondering what happens in that case, thank you for the
explanation, I had no idea.
>
> Because when one patch has problems, I toss the entire series from patchwork,
Is "v3b" good or shall I just use v4 instead?
Do I also need to change the version number (and add "Changes from
previous version" lines) to the subsequent patches, even though nothing
has actually changed)? Should have I used a cover letter to begin with?
> and by resubmitting the entire series again you are also giving me
important
> information, you're telling me that the subsequent patches in the series
> still apply cleanly even though the first one has changed.
That I don't understand. I thought it would be the other way around,
that's why I resubmitted only the one which changed.
If I resubmit the entire series, how can you tell patches 2 and 3 are
identical to the previous version I posted?
Last question: Is chain reply OK?
Thanks for your patience,
Gerlando
>
> I've tossed this patch too, resubmit this properly, thanks.
>
next prev parent reply other threads:[~2013-05-01 17:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-29 14:13 [PATCH v2 1/2] tipc: tipc_bcbearer_send(): simplify bearer selection Gerlando Falauto
2013-04-29 14:13 ` [PATCH v2 2/2] tipc: pskb_copy() buffers when sending on more than one bearer Gerlando Falauto
2013-04-29 19:45 ` David Miller
2013-04-29 19:44 ` [PATCH v2 1/2] tipc: tipc_bcbearer_send(): simplify bearer selection David Miller
2013-04-30 7:33 ` [PATCH v3 1/3] tipc: cosmetic: clean up comments Gerlando Falauto
2013-04-30 7:33 ` [PATCH v3 2/3] tipc: tipc_bcbearer_send(): simplify bearer selection Gerlando Falauto
2013-04-30 7:33 ` [PATCH v3 3/3] tipc: pskb_copy() buffers when sending on more than one bearer Gerlando Falauto
2013-04-30 11:54 ` [PATCH v3 1/3] tipc: cosmetic: clean up comments Sergei Shtylyov
2013-04-30 19:07 ` David Miller
2013-05-01 7:37 ` Gerlando Falauto
2013-05-01 16:18 ` Sergei Shtylyov
2013-05-01 16:41 ` [PATCH v3b 1/3] tipc: cosmetic: clean up comments and break a long line Gerlando Falauto
2013-05-01 17:16 ` David Miller
2013-05-01 17:35 ` Gerlando Falauto [this message]
2013-05-01 17:43 ` David Miller
2013-05-01 17:56 ` Gerlando Falauto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5181524D.6000207@keymile.com \
--to=gerlando.falauto@keymile.com \
--cc=Holger.Brunck@keymile.com \
--cc=davem@davemloft.net \
--cc=erik.hugne@ericsson.com \
--cc=jon.maloy@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).