From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>
Subject: Re: [PATCH 08/12] net/ethernet: MACB should depend on HAS_DMA
Date: Fri, 10 May 2013 10:22:34 +0200 [thread overview]
Message-ID: <518CAE4A.4060902@atmel.com> (raw)
In-Reply-To: <1368133494-22198-8-git-send-email-geert@linux-m68k.org>
On 09/05/2013 23:04, Geert Uytterhoeven :
> If NO_DMA=y:
>
> drivers/built-in.o: In function `macb_free_consistent':
> drivers/net/ethernet/cadence/macb.c:878: undefined reference to `dma_free_coherent'
> drivers/net/ethernet/cadence/macb.c:883: undefined reference to `dma_free_coherent'
> drivers/net/ethernet/cadence/macb.c:888: undefined reference to `dma_free_coherent'
> drivers/built-in.o: In function `macb_alloc_consistent':
> drivers/net/ethernet/cadence/macb.c:905: undefined reference to `dma_alloc_coherent'
> drivers/built-in.o: In function `macb_tx_interrupt':
> drivers/net/ethernet/cadence/macb.c:515: undefined reference to `dma_unmap_single'
> drivers/built-in.o: In function `macb_tx_error_task':
> drivers/net/ethernet/cadence/macb.c:457: undefined reference to `dma_unmap_single'
> drivers/built-in.o: In function `macb_start_xmit':
> drivers/net/ethernet/cadence/macb.c:838: undefined reference to `dma_map_single'
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: netdev@vger.kernel.org
> ---
> drivers/net/ethernet/cadence/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/ethernet/cadence/Kconfig b/drivers/net/ethernet/cadence/Kconfig
> index 0d9d6e6..768285e 100644
> --- a/drivers/net/ethernet/cadence/Kconfig
> +++ b/drivers/net/ethernet/cadence/Kconfig
> @@ -31,6 +31,7 @@ config ARM_AT91_ETHER
>
> config MACB
> tristate "Cadence MACB/GEM support"
> + depends on HAS_DMA
> select PHYLIB
> ---help---
> The Cadence MACB ethernet interface is found on many Atmel AT32 and
>
--
Nicolas Ferre
next prev parent reply other threads:[~2013-05-10 8:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1368133494-22198-1-git-send-email-geert@linux-m68k.org>
2013-05-09 21:04 ` [PATCH 03/12] net/ethernet: NET_CALXEDA_XGMAC should depend on HAS_DMA Geert Uytterhoeven
2013-05-11 23:28 ` David Miller
2013-05-09 21:04 ` [PATCH 04/12] net/ethernet: STMMAC_ETH " Geert Uytterhoeven
2013-05-11 23:28 ` David Miller
2013-05-09 21:04 ` [PATCH 05/12] net/wireless: ATH9K " Geert Uytterhoeven
2013-05-11 23:29 ` David Miller
2013-05-09 21:04 ` [PATCH 07/12] net/ethernet: ARM_AT91_ETHER " Geert Uytterhoeven
2013-05-10 8:22 ` Nicolas Ferre
2013-05-11 23:29 ` David Miller
2013-05-09 21:04 ` [PATCH 08/12] net/ethernet: MACB " Geert Uytterhoeven
2013-05-10 8:22 ` Nicolas Ferre [this message]
2013-05-11 23:29 ` David Miller
2013-05-09 21:04 ` [PATCH 10/12] caif: CAIF_VIRTIO " Geert Uytterhoeven
2013-05-11 23:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518CAE4A.4060902@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).