* Re: [PATCH] drivers: net: ethernet: broadcom: bcm63xx: use devm_ioremap_resource()
2013-05-12 15:56 [PATCH] drivers: net: ethernet: broadcom: bcm63xx: use devm_ioremap_resource() Laurent Navet
@ 2013-05-12 15:53 ` Laurent Navet
2013-05-12 18:38 ` Sergei Shtylyov
1 sibling, 0 replies; 4+ messages in thread
From: Laurent Navet @ 2013-05-12 15:53 UTC (permalink / raw)
To: davem; +Cc: cernekee, jogo, joe, netdev, linux-kernel, gregkh, Laurent Navet
Please, don't take this one
I'll send a more complete one later,
Sorry,
2013/5/12, Laurent Navet <laurent.navet@gmail.com>:
> Replace a call to deprecated devm_request_and_ioremap by
> devm_ioremap_resource.
>
> Found with coccicheck and this semantic patch:
> scripts/coccinelle/api/devm_ioremap_resource.cocci
>
> Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
> ---
> drivers/net/ethernet/broadcom/bcm63xx_enet.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c
> b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
> index 0b3e23e..9de4217 100644
> --- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c
> +++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
> @@ -1641,9 +1641,9 @@ static int bcm_enet_probe(struct platform_device
> *pdev)
> if (ret)
> goto out;
>
> - priv->base = devm_request_and_ioremap(&pdev->dev, res_mem);
> - if (priv->base == NULL) {
> - ret = -ENOMEM;
> + priv->base = devm_ioremap_resource(&pdev->dev, res_mem);
> + if (IS_ERR(priv->base)) {
> + ret = PTR_ERR(priv->base);
> goto out;
> }
>
> --
> 1.7.10.4
>
>
--
« On ne résout pas un problème avec les modes de pensée qui l’ont engendré. »
« You cannot solve current problems with current thinking. Current
problems are the result of current thinking »
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] drivers: net: ethernet: broadcom: bcm63xx: use devm_ioremap_resource()
@ 2013-05-12 15:56 Laurent Navet
2013-05-12 15:53 ` Laurent Navet
2013-05-12 18:38 ` Sergei Shtylyov
0 siblings, 2 replies; 4+ messages in thread
From: Laurent Navet @ 2013-05-12 15:56 UTC (permalink / raw)
To: davem; +Cc: cernekee, jogo, joe, netdev, linux-kernel, gregkh, Laurent Navet
Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource.
Found with coccicheck and this semantic patch:
scripts/coccinelle/api/devm_ioremap_resource.cocci
Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
---
drivers/net/ethernet/broadcom/bcm63xx_enet.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
index 0b3e23e..9de4217 100644
--- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c
+++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
@@ -1641,9 +1641,9 @@ static int bcm_enet_probe(struct platform_device *pdev)
if (ret)
goto out;
- priv->base = devm_request_and_ioremap(&pdev->dev, res_mem);
- if (priv->base == NULL) {
- ret = -ENOMEM;
+ priv->base = devm_ioremap_resource(&pdev->dev, res_mem);
+ if (IS_ERR(priv->base)) {
+ ret = PTR_ERR(priv->base);
goto out;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers: net: ethernet: broadcom: bcm63xx: use devm_ioremap_resource()
2013-05-12 15:56 [PATCH] drivers: net: ethernet: broadcom: bcm63xx: use devm_ioremap_resource() Laurent Navet
2013-05-12 15:53 ` Laurent Navet
@ 2013-05-12 18:38 ` Sergei Shtylyov
1 sibling, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2013-05-12 18:38 UTC (permalink / raw)
To: Laurent Navet; +Cc: davem, cernekee, jogo, joe, netdev, linux-kernel, gregkh
Hello.
On 05/12/2013 07:56 PM, Laurent Navet wrote:
> Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource.
>
> Found with coccicheck and this semantic patch:
> scripts/coccinelle/api/devm_ioremap_resource.cocci
>
> Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
> ---
> drivers/net/ethernet/broadcom/bcm63xx_enet.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
> index 0b3e23e..9de4217 100644
> --- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c
> +++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
> @@ -1641,9 +1641,9 @@ static int bcm_enet_probe(struct platform_device *pdev)
> if (ret)
> goto out;
>
> - priv->base = devm_request_and_ioremap(&pdev->dev, res_mem);
> - if (priv->base == NULL) {
> - ret = -ENOMEM;
> + priv->base = devm_ioremap_resource(&pdev->dev, res_mem);
> + if (IS_ERR(priv->base)) {
> + ret = PTR_ERR(priv->base);
> goto out;
> }
>
You may as well delete a check for 'res_mem' being NULL above
alloc_etherdev()
call since devm_ioremap_resource() checks for that too.
WBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] drivers: net: ethernet: broadcom: bcm63xx: use devm_ioremap_resource()
@ 2013-05-13 13:53 Laurent Navet
0 siblings, 0 replies; 4+ messages in thread
From: Laurent Navet @ 2013-05-13 13:53 UTC (permalink / raw)
To: davem
Cc: cernekee, sergei.shtylyov, jogo, joe, gregkh, netdev,
linux-kernel, Laurent Navet
Replace calls to deprecated devm_request_and_ioremap by devm_ioremap_resource.
also remove tests on 'res' since devm_ioremap_resource() checks for it
in a better form.
Found with coccicheck and this semantic patch:
scripts/coccinelle/api/devm_ioremap_resource.cocci
Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
---
drivers/net/ethernet/broadcom/bcm63xx_enet.c | 16 +++++++---------
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
index 0b3e23e..0497d0a 100644
--- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c
+++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
@@ -1628,7 +1628,7 @@ static int bcm_enet_probe(struct platform_device *pdev)
res_irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
res_irq_rx = platform_get_resource(pdev, IORESOURCE_IRQ, 1);
res_irq_tx = platform_get_resource(pdev, IORESOURCE_IRQ, 2);
- if (!res_mem || !res_irq || !res_irq_rx || !res_irq_tx)
+ if (!res_irq || !res_irq_rx || !res_irq_tx)
return -ENODEV;
ret = 0;
@@ -1641,9 +1641,9 @@ static int bcm_enet_probe(struct platform_device *pdev)
if (ret)
goto out;
- priv->base = devm_request_and_ioremap(&pdev->dev, res_mem);
- if (priv->base == NULL) {
- ret = -ENOMEM;
+ priv->base = devm_ioremap_resource(&pdev->dev, res_mem);
+ if (IS_ERR(priv->base)) {
+ ret = PTR_ERR(priv->base);
goto out;
}
@@ -1869,12 +1869,10 @@ static int bcm_enet_shared_probe(struct platform_device *pdev)
struct resource *res;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res)
- return -ENODEV;
- bcm_enet_shared_base = devm_request_and_ioremap(&pdev->dev, res);
- if (!bcm_enet_shared_base)
- return -ENOMEM;
+ bcm_enet_shared_base = devm_ioremap_resource(&pdev->dev, res);
+ if (IS_ERR(bcm_enet_shared_base))
+ return PTR_ERR(bcm_enet_shared_base);
return 0;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-05-13 13:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-12 15:56 [PATCH] drivers: net: ethernet: broadcom: bcm63xx: use devm_ioremap_resource() Laurent Navet
2013-05-12 15:53 ` Laurent Navet
2013-05-12 18:38 ` Sergei Shtylyov
2013-05-13 13:53 Laurent Navet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).