From: Eliezer Tamir <eliezer.tamir@linux.intel.com>
To: David Miller <davem@davemloft.net>
Cc: corbet@lwn.net, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, torvalds@linux-foundation.org,
akpm@linux-foundation.org, dwmw2@infradead.org,
eliezer@tamir.org.il
Subject: Re: [PATCH net-next] net: rename low latency sockets functions to busy poll
Date: Wed, 10 Jul 2013 08:21:21 +0300 [thread overview]
Message-ID: <51DCEF51.3080503@linux.intel.com> (raw)
In-Reply-To: <20130709.214156.1738814737075691376.davem@davemloft.net>
On 10/07/2013 07:41, David Miller wrote:
> From: Eliezer Tamir <eliezer.tamir@linux.intel.com>
> Date: Wed, 10 Jul 2013 06:29:16 +0300
>
>> If the following names changes are acceptable I will try to send out
>> a patch today.
>> 2. ndo_ll_poll -> ndo_busy_poll
>>
>> - not technically accurate since the ndo callback does not itself busy
>> poll, it's just used to implement it.
>
> I think this name change is accurate, it expresses the two elements of
> what it does. It's busy waiting, in that it's doing a synchronous
> scan of the device's RX queue, and it's polling just like NAPI polling
> does.
OK
> Well... what would be great would be to come up with some single
> interface that drivers can implement rather than having to have
> both napi->poll and netdevice_ops->ndo_ll_poll(). But that's a task
> for a later date.
>
> Therefore, ndo_busy_poll is probably best for now.
I will think about this, maybe we could even unify ndo_poll_controller.
It seems like said unified method would have to have an extra parameter
that would indicate from which context it was called:
1. from napi poll (bh)
2. from poll controller (with interrupts disabled)
3. from busy poll (user context)
-of course not for today.
> Nope, looks complete. And also do the manpage update.
Where do I find the repository for the manpages?
next prev parent reply other threads:[~2013-07-10 5:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-08 13:20 [PATCH net-next] net: rename low latency sockets functions to busy poll Eliezer Tamir
2013-07-08 16:37 ` Linus Torvalds
2013-07-08 17:14 ` Eliezer Tamir
2013-07-08 19:37 ` Linus Torvalds
2013-07-08 19:46 ` Eliezer Tamir
2013-07-08 19:59 ` Stephen Hemminger
2013-07-08 20:05 ` Stephen Hemminger
2013-07-08 20:10 ` Linus Torvalds
2013-07-09 2:27 ` David Miller
2013-07-09 22:25 ` Jonathan Corbet
2013-07-09 23:06 ` David Miller
2013-07-10 3:29 ` Eliezer Tamir
2013-07-10 4:41 ` David Miller
2013-07-10 5:21 ` Eliezer Tamir [this message]
2013-07-10 6:10 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DCEF51.3080503@linux.intel.com \
--to=eliezer.tamir@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=eliezer@tamir.org.il \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).