From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: Rami Rosen <ramirose@gmail.com>
Cc: davem@davemloft.net, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] ip6mr: change the prototype of ip6_mr_forward().
Date: Mon, 22 Jul 2013 22:47:54 +0200 [thread overview]
Message-ID: <51ED9A7A.1010008@6wind.com> (raw)
In-Reply-To: <1374364831-13190-1-git-send-email-ramirose@gmail.com>
Le 21/07/2013 02:00, Rami Rosen a écrit :
> This patch changes the prototpye of the ip6_mr_forward() method to return void
> instead of int.
>
> The ip6_mr_forward() method always returns 0; moreover, the return value of this
> method is not checked anywhere.
>
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> ---
> net/ipv6/ip6mr.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/net/ipv6/ip6mr.c b/net/ipv6/ip6mr.c
> index 583e8d4..6d78615 100644
> --- a/net/ipv6/ip6mr.c
> +++ b/net/ipv6/ip6mr.c
> @@ -110,8 +110,8 @@ static struct kmem_cache *mrt_cachep __read_mostly;
> static struct mr6_table *ip6mr_new_table(struct net *net, u32 id);
> static void ip6mr_free_table(struct mr6_table *mrt);
>
> -static int ip6_mr_forward(struct net *net, struct mr6_table *mrt,
> - struct sk_buff *skb, struct mfc6_cache *cache);
> +static void ip6_mr_forward(struct net *net, struct mr6_table *mrt,
> + struct sk_buff *skb, struct mfc6_cache *cache);
> static int ip6mr_cache_report(struct mr6_table *mrt, struct sk_buff *pkt,
> mifi_t mifi, int assert);
> static int __ip6mr_fill_mroute(struct mr6_table *mrt, struct sk_buff *skb,
> @@ -2069,8 +2069,8 @@ static int ip6mr_find_vif(struct mr6_table *mrt, struct net_device *dev)
> return ct;
> }
>
> -static int ip6_mr_forward(struct net *net, struct mr6_table *mrt,
> - struct sk_buff *skb, struct mfc6_cache *cache)
> +static void ip6_mr_forward(struct net *net, struct mr6_table *mrt,
> + struct sk_buff *skb, struct mfc6_cache *cache)
> {
> int psend = -1;
> int vif, ct;
> @@ -2151,12 +2151,11 @@ forward:
> last_forward:
> if (psend != -1) {
> ip6mr_forward2(net, mrt, skb, cache, psend);
> - return 0;
> + return;
> }
>
> dont_forward:
> kfree_skb(skb);
> - return 0;
> }
next prev parent reply other threads:[~2013-07-22 20:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-21 0:00 [PATCH net-next] ip6mr: change the prototype of ip6_mr_forward() Rami Rosen
2013-07-22 20:47 ` Nicolas Dichtel [this message]
2013-07-24 0:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51ED9A7A.1010008@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ramirose@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).